Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 8914003: Revert 113966 (updated revision range, but not actual expectations data) (Closed)

Created:
9 years ago by Nico
Modified:
9 years ago
Reviewers:
brettw
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 113966 (updated revision range, but not actual expectations data) - Update Linux size expectations to recent range of my code addition. Review URL: http://codereview.chromium.org/8913001 TBR=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M tools/perf_expectations/perf_expectations.json View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
9 years ago (2011-12-11 21:25:28 UTC) #1
brettw
I guess I don't understand. I ran the script...
9 years ago (2011-12-11 22:47:25 UTC) #2
Nico
I think the script might fail silently if the revision you put isn't available on ...
9 years ago (2011-12-11 23:09:13 UTC) #3
cmp
9 years ago (2011-12-12 20:41:07 UTC) #4
Thank you for cleaning this change up Nico and sorry things didn't work for you
right out of the gate Brett.

On 2011/12/11 23:09:13, Nico wrote:
> I think the script might fail silently if the revision you put isn't available
> on the perf dashboard. In that case, it silently makes no changes. Chase, does
> that sound right? If so, is there a reason the script doesn't fail loudly?

I would need to try replaying the change locally to verify what happens. 
Whatever happens, I expect it to behave sanely.  For example, the checksum
should have been updated.  There should never be a case where a CL is uploaded
with changes to any data for a perf trace and the checksum is not updated. 
Another issue was that the presubmit check should have run and caught that
changes were pending.

Powered by Google App Engine
This is Rietveld 408576698