Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: src/apinatives.js

Issue 8914: Add support for API accessors that prohibit overwriting by accessors... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/api.cc ('k') | src/bootstrapper.cc » ('j') | src/objects.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 } 75 }
76 ConfigureTemplateInstance(fun, data); 76 ConfigureTemplateInstance(fun, data);
77 } 77 }
78 return kApiFunctionCache[serialNumber]; 78 return kApiFunctionCache[serialNumber];
79 } 79 }
80 80
81 81
82 function ConfigureTemplateInstance(obj, data) { 82 function ConfigureTemplateInstance(obj, data) {
83 var properties = %GetTemplateField(data, kApiPropertyListOffset); 83 var properties = %GetTemplateField(data, kApiPropertyListOffset);
84 if (properties) { 84 if (properties) {
85 // Disable access checks while instantiating the object.
86 var requires_access_checks = %DisableAccessChecks(obj);
85 for (var i = 0; i < properties[0]; i += 3) { 87 for (var i = 0; i < properties[0]; i += 3) {
86 var name = properties[i + 1]; 88 var name = properties[i + 1];
87 var prop_data = properties[i + 2]; 89 var prop_data = properties[i + 2];
88 var attributes = properties[i + 3]; 90 var attributes = properties[i + 3];
89 var value = Instantiate(prop_data, name); 91 var value = Instantiate(prop_data, name);
90 %SetProperty(obj, name, value, attributes); 92 %SetProperty(obj, name, value, attributes);
91 } 93 }
94 if (requires_access_checks) %EnableAccessChecks(obj);
Kasper Lund 2008/10/30 12:32:27 Should this be in some sort of try-finally to play
92 } 95 }
93 } 96 }
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/bootstrapper.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698