Add support for API accessors that prohibit overwriting by accessors...

Add support for API accessors that prohibit overwriting by accessors
defined in JavaScript code by using __defineGetter__ and
__defineSetter__.

Also, disable access checks when configuring objects created from
templates.

Committed: http://code.google.com/p/v8/source/detail?r=656

[Kasper Lund, 2008-10-30 12:32:27]

LGTM.

http://codereview.chromium.org/8914/diff/1/6
File src/apinatives.js (right):

http://codereview.chromium.org/8914/diff/1/6#newcode94
Line 94: if (requires_access_checks) %EnableAccessChecks(obj);
Should this be in some sort of try-finally to play it safely?

http://codereview.chromium.org/8914/diff/1/5
File src/objects.cc (right):

http://codereview.chromium.org/8914/diff/1/5#newcode2302
Line 2302: // to be overwriten because allowing overwriting could potentially
overwritten

[Feng Qian, 2009-01-14 21:01:14]

hi this is wrong

You cannot turn off access check on an object and turn it on again.
Access check bit is set on Function's initial map, and an instance shares the
same map when it is created, then it is turned off, but the object can get a new
map when adding properties to it, turn-on check only modifies object's new map,
but not the old map.

This is likely the cause of the security issue 6264.


On 2008/10/30 11:42:35, Mads Ager wrote:
>