Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: pyautolib/pyauto.py

Issue 8913012: Fix flakiness and re-enable http search in find_in_page.FindMatchTests.testSearchInPDF (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/test/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« functional/find_in_page.py ('K') | « functional/find_in_page.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pyautolib/pyauto.py
===================================================================
--- pyautolib/pyauto.py (revision 113876)
+++ pyautolib/pyauto.py (working copy)
@@ -2657,7 +2657,7 @@
def FindInPage(self, search_string, forward=True,
match_case=False, find_next=False,
- tab_index=0, windex=0):
+ tab_index=0, windex=0, timeout=-1):
kkania 2011/12/15 00:41:36 It's too bad ActionTimeoutChanger can't be used fo
Nirnimesh 2011/12/15 05:22:04 I wasn't aware ActionTimeoutChanger is broken. I'm
"""Find the match count for the given search string and search parameters.
This is equivalent to using the find box.
@@ -2689,7 +2689,8 @@
'match_case' : match_case,
'find_next' : find_next,
}
- return self._GetResultFromJSONRequest(cmd_dict, windex=windex)
+ return self._GetResultFromJSONRequest(cmd_dict, windex=windex,
+ timeout=timeout)
def ExecuteJavascript(self, js, tab_index=0, windex=0, frame_xpath=''):
"""Executes a script in the specified frame of a tab.
« functional/find_in_page.py ('K') | « functional/find_in_page.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698