Fix flakiness and re-enable http search in find_in_page.FindMatchTests.testSearchInPDF

Fix flakiness and re-enable http search in find_in_page.FindMatchTests.testSearchInPDF

Add loop to _VerifySearchInPDFURL to try FindInPage 10 times and re-raise
the exception on the final loop. This is required because
_GetResultFromJSONRequest appears to timeout if called before the PDF has
loaded.

Add timeout parameter to pyauto.FindInPage to be passed to
_GetResultFromJSONRequest to speed up the loop in _VerifySearchInPDFURL
from the default of 45 seconds to 1 second.

Re-enable test on Mac.

BUG=107448, 70927, 93956
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114589

[vclarke1, 2011-12-14 19:45:51]

find_in_page.FindMatchTests.testSearchInPDF passed on try servers:
  mac:
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/7227/steps...
  linux:
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/7338/ste...
  win:
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/7698/steps...

[kkania, 2011-12-15 00:41:35]

lgtm

http://codereview.chromium.org/8913012/diff/1/functional/find_in_page.py
File functional/find_in_page.py (right):

http://codereview.chromium.org/8913012/diff/1/functional/find_in_page.py#newc...
functional/find_in_page.py:219: # loaded.
Add an explanation about the bug and a reference to crbug.com/<bug#>

http://codereview.chromium.org/8913012/diff/1/pyautolib/pyauto.py
File pyautolib/pyauto.py (right):

http://codereview.chromium.org/8913012/diff/1/pyautolib/pyauto.py#newcode2660
pyautolib/pyauto.py:2660: tab_index=0, windex=0, timeout=-1):
It's too bad ActionTimeoutChanger can't be used for this. Looking at the code,
it appears it's broken for any func that uses the json stuff.

http://codereview.chromium.org/8913012/diff/1/pyautolib/pyauto.py#newcode2670
pyautolib/pyauto.py:2670: window_index: The window index, default is 0.
add timeout here

[vclarke1, 2011-12-15 00:52:09]

Changes made per kkania.

http://codereview.chromium.org/8913012/diff/1/functional/find_in_page.py
File functional/find_in_page.py (right):

http://codereview.chromium.org/8913012/diff/1/functional/find_in_page.py#newc...
functional/find_in_page.py:219: # loaded.
On 2011/12/15 00:41:36, kkania wrote:
> Add an explanation about the bug and a reference to crbug.com/<bug#>

Done.

http://codereview.chromium.org/8913012/diff/1/pyautolib/pyauto.py
File pyautolib/pyauto.py (right):

http://codereview.chromium.org/8913012/diff/1/pyautolib/pyauto.py#newcode2670
pyautolib/pyauto.py:2670: window_index: The window index, default is 0.
On 2011/12/15 00:41:36, kkania wrote:
> add timeout here

Done.

[commit-bot: I haz the power, 2011-12-15 00:53:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vclarke@chromium.org/8913012/4001

[commit-bot: I haz the power, 2011-12-15 00:53:40]

Presubmit check for 8913012-4001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
Found line ending with white spaces in:

***************
chrome/test/functional/find_in_page.py, line 246
***************

[commit-bot: I haz the power, 2011-12-15 01:06:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vclarke@chromium.org/8913012/6001

[commit-bot: I haz the power, 2011-12-15 03:21:24]

Change committed as 114589

[Nirnimesh, 2011-12-15 05:22:04]

http://codereview.chromium.org/8913012/diff/1/pyautolib/pyauto.py
File pyautolib/pyauto.py (right):

http://codereview.chromium.org/8913012/diff/1/pyautolib/pyauto.py#newcode2660
pyautolib/pyauto.py:2660: tab_index=0, windex=0, timeout=-1):
I wasn't aware ActionTimeoutChanger is broken. I'm sure it's used in some other
places.