Issue 8913009: Hide the process of instantiating NotificationServiceImpl from embedders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8913009: Hide the process of instantiating NotificationServiceImpl from embedders. (Closed)

Created:
9 years ago by tfarina

Modified:
9 years ago

Reviewers:
jam

CC:
chromium-reviews, jstritar+watch_chromium.org, ncarter (slow), akalin, Raghu Simha, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., dhollowa+watch_chromium.org, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Hide the process of instantiating NotificationServiceImpl from embedders. Make NotificationService handle the process of instantiating NotificationServiceImpl instead. BUG=98716 R=jam@chromium.org TBR=akalin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114454

Patch Set 1 #

Patch Set 2 : #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -12 lines)			Patch
M	chrome/browser/password_manager/password_store_mac.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/glue/typed_url_change_processor.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_test_util.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_test_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/util/extensions_activity_monitor_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/page_action_image_view.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/webdata/web_database.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/notification_service_impl.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/public/browser/notification_service.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

9 years ago (2011-12-14 17:37:57 UTC) #2

lgtm, thanks

perhaps also add an entry in chrome\browser\DEPS to enforce that people don't
include notification_service_impl.h anymore

Expand Messages | Collapse Messages