Fix missing trampolines for named arguments.

frog/var_member.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** A dynamic member stub. */
 class VarMember {
   final String name;
   bool isGenerated = false;
 
   VarMember(this.name);
@@ skipping 162 matching lines @@
         return false;
       }
 
       // If we have the right number of parameters, or all defaults would be
       // filled in as "undefined" anyway, we can just call the method directly.
       for (int i = args.length; i < method.parameters.length; i++) {
         if (method.parameters[i].value.code != 'null') {
           return false;
         }
       }
-      return method.namesInOrder(args);
+      return method.namesInHomePositions(args);
     } else {
       return false;
     }
   }
 }
 
 /**
  * A special member with a mangled name that represents a dynamic call
  * (i.e. a call with multiple valid targets). We generate this if we have
  * a dynamic call that needs different implementation methods for different
@@ skipping 25 matching lines @@
 
     bool hasObjectType = false;
     for (var member in members) {
       // Invoke the member with the stub args (this gives us the method body),
       // then create the stub method.
       final type = member.declaringType;
       final target = new Value(type, 'this', node.span);
       var result = member.invoke(context, node, target, args, isDynamic:true);
       var stub = new VarMethodStub(name, member, args, 'return ' + result.code);
       type.varStubs[stub.name] = stub;
-
       if (type.isObject) hasObjectType = true;
     }
 
     // Create a noSuchMethod fallback on Object if needed.
     // Some methods, like toString and == already have a fallback on Object.
     if (!hasObjectType) {
       final target = new Value(world.objectType, 'this', node.span);
       var result = target.invokeNoSuchMethod(context, baseName, node, args);
       var stub = new VarMethodStub(name, null, args, 'return ' + result.code);
       world.objectType.varStubs[stub.name] = stub;
     }
   }
 
   // TODO(jmesserly): get rid of this as it's unused now
   void generate(CodeWriter code) {}
 }
 
 String _getCallStubName(String name, Arguments args) {
+  // TODO: This code needs global knowledge to ensure the stub name does not
+  // collide with any other name.

[Jennifer Messerly, 2011/12/14 19:15:33]

Some examples would be helpful--I'm not sure what kinds of things you're worried
about.

FWIW, there are some things on "world" that might help:
    toJsIdentifier -> currently built assuming ':' appears in only certain
positions, but could be generalized like you did here.
    _addTopName -> tracks top level names to handle collisions

we do prevent user methods from containing a single '$', and our special ones
should only have a leading $. (i'm also moving the special ones to natives.dart,
where they go through better name collision detection, fwiw)

[sra1, 2011/12/14 22:04:32]

Done.

   final nameBuilder = new StringBuffer('${name}\$${args.bareCount}');
   for (int i = args.bareCount; i < args.length; i++) {
-    nameBuilder.add('\$').add(args.getName(i));
+    var name = args.getName(i);
+    nameBuilder.add('\$');
+    if (name.contains('\$')) {
+      // Disambiguate "a:b:" from "a$b:"
+      nameBuilder.add('${name.length}');

[Jennifer Messerly, 2011/12/14 19:15:33]

do you need length here, or would it be enough to add something like _ before
and after the name? mostly asking out of curiosity -- the length works for me
too.

[sra1, 2011/12/14 22:04:32]

I've kept the length.  If you put '_' in there, how do you tell the added '_'
from pre-existing ones?  A good way to think about this kind of encoding is to
imagine the code for reversing the transformation.

+    }
+    nameBuilder.add(name);
   }
   return nameBuilder.toString();
 }