Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 8912009: Move BrowserMessageFilter to public, and into content namespace. (Closed)

Created:
9 years ago by Jói
Modified:
8 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, vrk (LEFT CHROMIUM), yusukes+watch_chromium.org, mihaip+watch_chromium.org, dcheng, kinuko+watch, ddorwin+watch_chromium.org, acolwell+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, annacc+watch_chromium.org, ihf+watch_chromium.org, jstritar+watch_chromium.org, kkania, fischman+watch_chromium.org, penghuang+watch_chromium.org, dpranke-watch+content_chromium.org, scherkus (not reviewing), michaeln, hclam+watch_chromium.org, Aaron Boodman, robertshield, Paweł Hajdan Jr., James Su, tfarina
Visibility:
Public.

Description

Move BrowserMessageFilter to public, and into content namespace. TBR=abodenha@chromium.org for chrome/browser/printing/OWNERS BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114758

Patch Set 1 #

Patch Set 2 : Merge to LKGR. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -128 lines) Patch
M chrome/browser/automation/automation_resource_message_filter.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_resource_message_filter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_benchmarking_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_plugin_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_webrequest_api.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/printing/printing_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/plugin_info_message_filter.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_state_message_filter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_platform_mac.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_platform_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/appcache/appcache_dispatcher_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/appcache/appcache_dispatcher_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/debugger/worker_devtools_message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/device_orientation/message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/file_system/file_system_dispatcher_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/file_system/file_system_dispatcher_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/geolocation/geolocation_dispatcher_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/dom_storage_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/dom_storage_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/mime_registry_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/profiler_message_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/profiler_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/blob_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/blob_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/clipboard_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/database_message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/database_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/file_utilities_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/gamepad_browser_message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/gamepad_browser_message_filter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/pepper_file_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/pepper_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/quota_dispatcher_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 3 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/resource_message_filter.h View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/resource_message_filter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/socket_stream_dispatcher_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper.h View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/speech/speech_input_dispatcher_host.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/trace_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/trace_message_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/trace_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/worker_host/worker_message_filter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/worker_host/worker_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/browser/browser_message_filter.h View 3 chunks +7 lines, -3 lines 0 comments Download
A + content/public/browser/browser_message_filter.cc View 3 chunks +6 lines, -3 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
Jói
Real changes are in the A+ and D files, and the .gypi file, rest is ...
9 years ago (2011-12-13 15:24:58 UTC) #1
jam
lgtm
9 years ago (2011-12-13 16:27:03 UTC) #2
tfarina
http://codereview.chromium.org/8912009/diff/14001/content/public/browser/browser_message_filter.cc File content/public/browser/browser_message_filter.cc (right): http://codereview.chromium.org/8912009/diff/14001/content/public/browser/browser_message_filter.cc#newcode16 content/public/browser/browser_message_filter.cc:16: using content::BrowserMessageFilter; nit: you don't need this using here.
9 years ago (2011-12-15 15:16:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8912009/14001
9 years ago (2011-12-16 01:05:14 UTC) #4
commit-bot: I haz the power
Presubmit check for 8912009-14001 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-16 01:06:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8912009/14001
9 years ago (2011-12-16 01:33:02 UTC) #6
commit-bot: I haz the power
Change committed as 114758
9 years ago (2011-12-16 03:00:14 UTC) #7
jam
I think during the merge to lkgr there was a conflict and the old files ...
8 years, 10 months ago (2012-02-14 15:52:46 UTC) #8
Jói
8 years, 10 months ago (2012-02-14 16:05:38 UTC) #9
Whoops, I'll clean that up.

On Tue, Feb 14, 2012 at 3:52 PM,  <jam@chromium.org> wrote:
> I think during the merge to lkgr there was a conflict and the old files lost
> their delete attribute. i noticed this because i saw two copies of this file
> in
> cs
>
> http://codereview.chromium.org/8912009/

Powered by Google App Engine
This is Rietveld 408576698