Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 8910024: Add ExpireHistoryBackend::DeleteURLs method (Closed)

Created:
9 years ago by akalin
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Add ExpireHistoryBackend::DeleteURLs method This is primarily used by the sync typed URL performance tests. This method helps stabilize the perf numbers since there's only a single notification that is emitted (instead of one per URL). BUG=107040 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114572

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -41 lines) Patch
M chrome/browser/history/expire_history_backend.h View 1 3 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/history/expire_history_backend.cc View 1 1 chunk +33 lines, -25 lines 3 comments Download
M chrome/browser/history/history_backend.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
akalin
+sky for review
9 years ago (2011-12-14 23:00:18 UTC) #1
sky
http://codereview.chromium.org/8910024/diff/1/chrome/browser/history/expire_history_backend.cc File chrome/browser/history/expire_history_backend.cc (right): http://codereview.chromium.org/8910024/diff/1/chrome/browser/history/expire_history_backend.cc#newcode200 chrome/browser/history/expire_history_backend.cc:200: if (!main_db_) Implement this in terms of DeleteURLs.
9 years ago (2011-12-14 23:16:49 UTC) #2
akalin
PTAL http://codereview.chromium.org/8910024/diff/1/chrome/browser/history/expire_history_backend.cc File chrome/browser/history/expire_history_backend.cc (right): http://codereview.chromium.org/8910024/diff/1/chrome/browser/history/expire_history_backend.cc#newcode200 chrome/browser/history/expire_history_backend.cc:200: if (!main_db_) On 2011/12/14 23:16:49, sky wrote: > ...
9 years ago (2011-12-14 23:43:08 UTC) #3
sky
LGTM
9 years ago (2011-12-14 23:54:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/8910024/4003
9 years ago (2011-12-14 23:57:40 UTC) #5
commit-bot: I haz the power
Change committed as 114572
9 years ago (2011-12-15 02:08:01 UTC) #6
sky
9 years ago (2011-12-16 22:00:11 UTC) #7
http://codereview.chromium.org/8910024/diff/4003/chrome/browser/history/expir...
File chrome/browser/history/expire_history_backend.cc (right):

http://codereview.chromium.org/8910024/diff/4003/chrome/browser/history/expir...
chrome/browser/history/expire_history_backend.cc:212: return;  // Nothing to
delete.
This should be continue now.

http://codereview.chromium.org/8910024/diff/4003/chrome/browser/history/expir...
chrome/browser/history/expire_history_backend.cc:234:
DeleteFaviconsIfPossible(dependencies.affected_favicons);
This is wrong now. In particular if the previous url was bookmarked, this still
ends up deleting favicons.

http://codereview.chromium.org/8910024/diff/4003/chrome/browser/history/expir...
chrome/browser/history/expire_history_backend.cc:236: if (text_db_)
This should be outside the loop.

Powered by Google App Engine
This is Rietveld 408576698