Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: src/platform/update_engine/subprocess.cc

Issue 891002: AU: Delta Diff Generator (Closed)
Patch Set: fixes for review Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/platform/update_engine/subprocess.cc
diff --git a/src/platform/update_engine/subprocess.cc b/src/platform/update_engine/subprocess.cc
index 299d7588bb3de2d2dd86ebc3d36ccafe8764e607..89b6cadd03fd56fa88ecf875d78a6040cedee9ca 100644
--- a/src/platform/update_engine/subprocess.cc
+++ b/src/platform/update_engine/subprocess.cc
@@ -80,7 +80,7 @@ void Subprocess::CancelExec(uint32 tag) {
bool Subprocess::SynchronousExec(const std::vector<std::string>& cmd,
int* return_code) {
- GError *err;
+ GError *err = NULL;
scoped_array<char *> argv(new char*[cmd.size() + 1]);
for (unsigned int i = 0; i < cmd.size(); i++) {
argv[i] = strdup(cmd[i].c_str());
@@ -100,6 +100,8 @@ bool Subprocess::SynchronousExec(const std::vector<std::string>& cmd,
return_code,
&err);
FreeArgv(argv.get());
+ if (err)
+ LOG(INFO) << "err is: " << err->code << ", " << err->message;
return success;
}
« no previous file with comments | « src/platform/update_engine/postinstall_runner_action_unittest.cc ('k') | src/platform/update_engine/test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698