Issue 8910011: Enfore through chrome/browser/DEPS that it can't include notification_service_impl.h anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8910011: Enfore through chrome/browser/DEPS that it can't include notification_service_impl.h anymore. (Closed)

Created:
9 years ago by tfarina

Modified:
9 years ago

Reviewers:
jam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enfore through chrome/browser/DEPS that it can't include notification_service_impl.h anymore. BUG=98716 R=jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114632

Patch Set 2 : jam review #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/DEPS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm http://codereview.chromium.org/8910011/diff/1/chrome/browser/DEPS File chrome/browser/DEPS (right): http://codereview.chromium.org/8910011/diff/1/chrome/browser/DEPS#newcode32 chrome/browser/DEPS:32: "-content/browser/notification_service_impl.h" nit: just please put this at line ...

9 years ago (2011-12-15 01:14:56 UTC) #2

tfarina

9 years ago (2011-12-15 13:34:03 UTC) #3

http://codereview.chromium.org/8910011/diff/1/chrome/browser/DEPS
File chrome/browser/DEPS (right):

http://codereview.chromium.org/8910011/diff/1/chrome/browser/DEPS#newcode32
chrome/browser/DEPS:32: "-content/browser/notification_service_impl.h"
On 2011/12/15 01:14:56, John Abd-El-Malek wrote:
> nit: just please put this at line 31, and put a blank line after it. that way
we
> can group all the content/browser lines together

Done.

Expand Messages | Collapse Messages

Issue 8910011: Enfore through chrome/browser/DEPS that it can't include notification_service_impl.h anymore. (Closed)

Description

Patch Set 1 #

Patch Set 2 : jam review #

Messages