Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 8910004: Optimize setting the font when drawing in RenderTextLinux. (Closed)

Created:
9 years ago by Alexei Svitkine (slow)
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Optimize setting the font when drawing in RenderTextLinux. Avoid creating a temporary |gfx::Font| just to get its name and size to pass it to Skia. Note: There's room for further optimizations here, such as caching, which I plan to look at in a future CL. BUG=107394 TEST=Run aura and check that omnibox still looks fine. Run about:tracing and check that time used by this code is significantly decreased. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114541

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -37 lines) Patch
M ui/gfx/pango_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/pango_util.cc View 2 chunks +34 lines, -0 lines 0 comments Download
M ui/gfx/platform_font_pango.cc View 3 chunks +2 lines, -34 lines 0 comments Download
M ui/gfx/render_text.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/render_text.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M ui/gfx/render_text_linux.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexei Svitkine (slow)
9 years ago (2011-12-14 18:03:05 UTC) #1
sky
LGTM
9 years ago (2011-12-14 18:31:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8910004/4001
9 years ago (2011-12-14 18:38:48 UTC) #3
commit-bot: I haz the power
Try job failure for 8910004-4001 (retry) on mac_rel for step "ui_tests". It's a second try, ...
9 years ago (2011-12-14 20:59:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8910004/4001
9 years ago (2011-12-14 21:07:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8910004/4001
9 years ago (2011-12-14 22:58:44 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-15 00:24:11 UTC) #7
Change committed as 114541

Powered by Google App Engine
This is Rietveld 408576698