Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 8910: Code cleanup & simplification.... (Closed)

Created:
12 years, 1 month ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Code cleanup & simplification. Moves the calls to tracer and UpdateLiveObjectCount inside the call to (inlined) SetMark. Removes global object counter. Committed: http://code.google.com/p/v8/source/detail?r=688

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -42 lines) Patch
M src/mark-compact.h View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M src/mark-compact.cc View 1 2 8 chunks +8 lines, -39 lines 0 comments Download
M src/v8-counters.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
William Hesse
As part of inlining the tracing and debug object-counting into SetMark during marking GC, I ...
12 years, 1 month ago (2008-10-30 11:18:34 UTC) #1
Patrick Johnson
LGTM I only reviewed the change to remove the global objects counter. We're not using ...
12 years, 1 month ago (2008-10-30 16:04:25 UTC) #2
Feng Qian
Global object counter is pretty useful for debugging memory leaks. Does it cause trouble for ...
12 years, 1 month ago (2008-10-30 16:36:51 UTC) #3
Kevin Millikin (Chromium)
12 years, 1 month ago (2008-11-04 09:59:32 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698