Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 8909017: Fix compile on linux_redux bots (Closed)

Created:
9 years ago by Ryan Sleevi
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix compile on linux_redux bots, caused by http://crrev.com/113808 linux_redux does not have safe_browsing enabled in the GYP variables, which causes all of chrome/browser/safe_browsing to be excluded from the chrome_browser target - including safe_browsing_tab_observer.[cc,h] This enables a stub SafeBrowsingTabObserver to be compiled when safe_browsing==0, fixing the linker errors from TabContentsWrapper having a SafeBrowsingTabObserver member. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114553

Patch Set 1 #

Patch Set 2 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/safe_browsing/safe_browsing_tab_observer.cc View 1 2 chunks +11 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ryan Sleevi
sail: rubberstamp? avi: review || fyi?
9 years ago (2011-12-14 23:02:52 UTC) #1
Ryan Sleevi
mattm: chrome/browser/safe_browsing/OWNERS stamp
9 years ago (2011-12-14 23:06:28 UTC) #2
sail
lgtm
9 years ago (2011-12-14 23:08:39 UTC) #3
Avi (use Gerrit)
D'oh. LGTM
9 years ago (2011-12-14 23:13:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8909017/1
9 years ago (2011-12-14 23:13:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8909017/6001
9 years ago (2011-12-14 23:34:35 UTC) #6
mattm
lgtm Maybe mention in the description which cl broke it.
9 years ago (2011-12-14 23:52:00 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-15 00:53:46 UTC) #8
Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

Powered by Google App Engine
This is Rietveld 408576698