Issue 8909015: Implement RunFileChooser for ExtensionHost, so that file input elements work in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8909015: Implement RunFileChooser for ExtensionHost, so that file input elements work in (Closed)

Created:
9 years ago by Matt Perry

Modified:
9 years ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, jstritar+watch_chromium.org, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement RunFileChooser for ExtensionHost, so that file input elements work in extension popups. Also fix a leak that happens if the renderer that initiated a file chooser is closed before the file chooser appears. BUG=104222 TEST=see bug for repro Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114692

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -1 line)			Patch
M	chrome/browser/extensions/extension_host.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/file_select_helper.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages