Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: content/renderer/media/audio_device.h

Issue 8909006: Fix start/stop of html5 audio stream and race condition when pausing. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/audio_device.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/audio_device.h
===================================================================
--- content/renderer/media/audio_device.h (revision 113847)
+++ content/renderer/media/audio_device.h (working copy)
@@ -81,9 +81,10 @@
public:
class CONTENT_EXPORT RenderCallback {
public:
- virtual void Render(const std::vector<float*>& audio_data,
- size_t number_of_frames,
- size_t audio_delay_milliseconds) = 0;
+ // Fills entire buffer, returns actual number of frames it got from source.
+ virtual size_t Render(const std::vector<float*>& audio_data,
Chris Rogers 2011/12/14 20:48:35 probably should add comment about the return value
enal1 2011/12/14 22:14:54 Made existing comment more clear.
+ size_t number_of_frames,
+ size_t audio_delay_milliseconds) = 0;
protected:
virtual ~RenderCallback() {}
};
@@ -162,7 +163,8 @@
// Method called on the audio thread (+ one call on the IO thread) ----------
// Calls the client's callback for rendering audio. There will also be one
// initial call on the IO thread before the audio thread has been created.
- void FireRenderCallback(int16* data);
+ // Returns actual number of filled frames.
+ size_t FireRenderCallback(int16* data);
Chris Rogers 2011/12/14 20:48:35 comment about return value
enal1 2011/12/14 22:14:54 Done.
// DelegateSimpleThread::Delegate implementation.
virtual void Run() OVERRIDE;
« no previous file with comments | « no previous file | content/renderer/media/audio_device.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698