Enable ChromeFrame net tests for IE versions 8 and below. Changes include the following:-

Enable ChromeFrame net tests for IE versions 8 and below. Changes include the following:-

1. Get rid of the dummy AtlModule registration in the chrome frame net test suite. This is no longer needed
   as there is an Atlmodule instance instantiated by the content code.

2. The TestSuite and NetTestSuite classes now provide special protected constructors which allow
   test instances to control whether an AtExitManager instance is created for the duration of the
   test. The ChromeFrame net test suite reuses the AtExitManager instance created in BrowserMain.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435

BUG=105435
TEST=ChromeFrame net tests should now run on the builders.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114559

[rvargas (doing something else), 2011-12-14 23:32:11]

net/ LGTM.

btw, AtlModule is going away from the CF tests, not from net (as the CL
description implies).

http://codereview.chromium.org/8907054/diff/3002/chrome_frame/test/net/fake_e...
File chrome_frame/test/net/fake_external_tab.cc (right):

http://codereview.chromium.org/8907054/diff/3002/chrome_frame/test/net/fake_e...
chrome_frame/test/net/fake_external_tab.cc:267: // Newly added tests which fail
in CF.
nit: this comment is bound to be stale pretty soon.

I'm guessing that we don't want to pass these tests ever (by the lack of bug #).

[ananta, 2011-12-14 23:54:42]

Updated the test description to indicate that AtlModule is going away from
chrome frame net tests.

http://codereview.chromium.org/8907054/diff/3002/chrome_frame/test/net/fake_e...
File chrome_frame/test/net/fake_external_tab.cc (right):

http://codereview.chromium.org/8907054/diff/3002/chrome_frame/test/net/fake_e...
chrome_frame/test/net/fake_external_tab.cc:267: // Newly added tests which fail
in CF.
On 2011/12/14 23:32:11, rvargas wrote:
> nit: this comment is bound to be stale pretty soon.
> 
> I'm guessing that we don't want to pass these tests ever (by the lack of bug
#).
> 

Updated the comment to reflect that these tests are unsupported in CF.

[brettw, 2011-12-15 00:00:15]

lgtm

http://codereview.chromium.org/8907054/diff/4002/base/test/test_suite.cc
File base/test/test_suite.cc (right):

http://codereview.chromium.org/8907054/diff/4002/base/test/test_suite.cc#newc...
base/test/test_suite.cc:102: if (create_at_exit_manager) {
No {} to match surrounding code.

[ananta, 2011-12-15 00:14:55]

http://codereview.chromium.org/8907054/diff/4002/base/test/test_suite.cc
File base/test/test_suite.cc (right):

http://codereview.chromium.org/8907054/diff/4002/base/test/test_suite.cc#newc...
base/test/test_suite.cc:102: if (create_at_exit_manager) {
On 2011/12/15 00:00:15, brettw wrote:
> No {} to match surrounding code.

Done.