Remove TOUCH_UI code in chrome_constants.cc

Remove TOUCH_UI code in chrome_constants.cc. I purposely preserved kEnableTouchIcon.


BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114532

[Emmanuel Saint-loubert-Bié, 2011-12-14 21:24:00]

Hi Rick,

Please review this CL.

-- Emmanuel

[Rick Byers, 2011-12-14 21:46:19]

On 2011/12/14 21:24:00, Emmanuel Saint-loubert wrote:
> Hi Rick,
> 
> Please review this CL.
> 
> -- Emmanuel

What exactly does kEnableTouchIcon do?  If it makes sense to have in Aura, then
perhaps we should just set it based on the --touch-optimized-ui flag now?  I'm
not sure we want dead/unused touch-related functionality in the code - if we
don't end up using it it might hang around for a long time.  

If you think it we're probably going to want it but should leave it as dead code
for now, then perhaps we should file a bug to track and put a TODO in the code
referencing the bug to help explain why there is dead code?

Rick

[Rick Byers, 2011-12-14 21:58:19]

On 2011/12/14 21:46:19, Rick Byers wrote:
> On 2011/12/14 21:24:00, Emmanuel Saint-loubert wrote:
> > Hi Rick,
> > 
> > Please review this CL.
> > 
> > -- Emmanuel
> 
> What exactly does kEnableTouchIcon do?  If it makes sense to have in Aura,
then
> perhaps we should just set it based on the --touch-optimized-ui flag now?  I'm
> not sure we want dead/unused touch-related functionality in the code - if we
> don't end up using it it might hang around for a long time.  
> 
> If you think it we're probably going to want it but should leave it as dead
code
> for now, then perhaps we should file a bug to track and put a TODO in the code
> referencing the bug to help explain why there is dead code?

LGTM

Emmanuel and I talked offline, it indeed makes sense to leave this here disabled
by default.

[commit-bot: I haz the power, 2011-12-14 21:59:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/saintlou@chromium.org/8907048/1

[commit-bot: I haz the power, 2011-12-15 00:02:20]

Change committed as 114532