AURA/X11: Handle VKEY_MENU accelerator on content area

AURA/X11: Handle VKEY_MENU accelerator on content area
-Moved the code to handle vkey_menu to focus manager.
-Unify the code between win/aura/gtk to handle unhandled web keyevent. We were using different code path for unhandled web keyboard for regular page and login. This should fix this issue also.
-Improved focus test not to use fixed wait. This should also speedup the test a bit.
-Removed OmniboxViewViews tests that runs only on views/gtk. This is no longer supported and we can re-enable for win when ready.

BUG=99861, 106998, 108480, 108459
TEST=manual: set focus to content area and hit alt key. the focus should be set to wrench menu on release.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116541

[oshima, 2011-12-16 00:34:36]

http://codereview.chromium.org/8907029/diff/25022/chrome/browser/ui/views/unh...
File chrome/browser/ui/views/unhandled_keyboard_event_handler_aurax11.cc
(right):

http://codereview.chromium.org/8907029/diff/25022/chrome/browser/ui/views/unh...
chrome/browser/ui/views/unhandled_keyboard_event_handler_aurax11.cc:71: // use
|KeyEvent(const NativeEvent)| constructor.
I'm working on NativeWebKeyboard fix in separate CL and the code above and below
will be replaced with just

views::KeyEvent views_event(event.os_event);

[oshima, 2011-12-16 19:52:25]

On 2011/12/16 00:34:36, oshima wrote:
>
http://codereview.chromium.org/8907029/diff/25022/chrome/browser/ui/views/unh...
> File chrome/browser/ui/views/unhandled_keyboard_event_handler_aurax11.cc
> (right):
> 
>
http://codereview.chromium.org/8907029/diff/25022/chrome/browser/ui/views/unh...
> chrome/browser/ui/views/unhandled_keyboard_event_handler_aurax11.cc:71: // use
> |KeyEvent(const NativeEvent)| constructor.
> I'm working on NativeWebKeyboard fix in separate CL and the code above and
below
> will be replaced with just
> 
> views::KeyEvent views_event(event.os_event);

I uploaded new patch with this change. PTAL.

[oshima, 2011-12-17 00:08:44]

Please hold. TabMoveCursorToEnd failure seems to be real and I'm investigating.

On 2011/12/16 19:52:25, oshima wrote:
> On 2011/12/16 00:34:36, oshima wrote:
> >
>
http://codereview.chromium.org/8907029/diff/25022/chrome/browser/ui/views/unh...
> > File chrome/browser/ui/views/unhandled_keyboard_event_handler_aurax11.cc
> > (right):
> > 
> >
>
http://codereview.chromium.org/8907029/diff/25022/chrome/browser/ui/views/unh...
> > chrome/browser/ui/views/unhandled_keyboard_event_handler_aurax11.cc:71: //
use
> > |KeyEvent(const NativeEvent)| constructor.
> > I'm working on NativeWebKeyboard fix in separate CL and the code above and
> below
> > will be replaced with just
> > 
> > views::KeyEvent views_event(event.os_event);
> 
> I uploaded new patch with this change. PTAL.

[oshima, 2011-12-22 21:43:44]

Fixed the issue, so please take another look.
 OmniboxViewViews on linux/gtk was failing but since we no longer support this
configuration, I just removed the test for now (views tab handling and gtk's tab
handling were interfering each other. let me know if you know the details). I
filed a bug crbug.com/108459 to re-enable for Windows when this is ready for
win.


On 2011/12/17 00:08:44, oshima wrote:
> Please hold. TabMoveCursorToEnd failure seems to be real and I'm
investigating.
> 
> On 2011/12/16 19:52:25, oshima wrote:
> > On 2011/12/16 00:34:36, oshima wrote:
> > >
> >
>
http://codereview.chromium.org/8907029/diff/25022/chrome/browser/ui/views/unh...
> > > File chrome/browser/ui/views/unhandled_keyboard_event_handler_aurax11.cc
> > > (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/8907029/diff/25022/chrome/browser/ui/views/unh...
> > > chrome/browser/ui/views/unhandled_keyboard_event_handler_aurax11.cc:71: //
> use
> > > |KeyEvent(const NativeEvent)| constructor.
> > > I'm working on NativeWebKeyboard fix in separate CL and the code above and
> > below
> > > will be replaced with just
> > > 
> > > views::KeyEvent views_event(event.os_event);
> > 
> > I uploaded new patch with this change. PTAL.

[Ben Goodger (Google), 2011-12-22 23:11:36]

lgtm

[commit-bot: I haz the power, 2011-12-23 00:03:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8907029/40002

[commit-bot: I haz the power, 2011-12-23 00:03:48]

Can't process patch for file chrome/chrome_browser.gypi.
File's status is None, patchset upload is incomplete.

[commit-bot: I haz the power, 2012-01-05 17:26:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8907029/45025

[commit-bot: I haz the power, 2012-01-05 17:27:04]

Presubmit check for 8907029-45025 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Presubmit checks took 3.0s to calculate.

[sky, 2012-01-05 18:55:46]

ui/omnibox LGTM

[commit-bot: I haz the power, 2012-01-05 18:56:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8907029/45025

[commit-bot: I haz the power, 2012-01-05 20:43:43]

Change committed as 116541