Issue 8907018: Renaming REMOVE_LSO_DATA to REMOVE_PLUGIN_DATA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8907018: Renaming REMOVE_LSO_DATA to REMOVE_PLUGIN_DATA (Closed)

Created:
9 years ago by Mike West

Modified:
9 years ago

Reviewers:
Bernhard Bauer, jochen (gone - plz use gerrit)

CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Renaming REMOVE_LSO_DATA to REMOVE_PLUGIN_DATA Removing plugin data is different to removing only LSO data. Moreover, we call out to content::PluginDataRemover to do the work: we should have an external name here that's consistent. This CL's tests depend on http://codereview.chromium.org/8907015/ landing. It shouldn't be landed until that patch is approved. BUG=107355 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114240

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -32 lines)			Patch
M	chrome/browser/browsing_data_remover.h	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/browsing_data_remover.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/browsing_data_remover_unittest.cc	View	7 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/extensions/extension_clear_api.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_clear_api.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/options/clear_browser_data_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mike West

Hello Jochen and Bernhard! Would one of you mind evaluating this change? Thanks!

9 years ago (2011-12-13 15:08:17 UTC) #1

Mike West

On 2011/12/13 15:08:17, Mike West (chromium) wrote: > Hello Jochen and Bernhard! Would one of ...

9 years ago (2011-12-13 15:09:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/8907018/1

9 years ago (2011-12-13 17:18:38 UTC) #4

Change committed as 114240

Expand Messages | Collapse Messages