Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 8907010: Fix flaky tests in EndToEndAsyncTest in dbus_unittests. (Closed)

Created:
9 years ago by satorux1
Modified:
9 years ago
Reviewers:
hashimoto
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix flaky tests in EndToEndAsyncTest in dbus_unittests. We should wait for signal connection, for each signal. Otherwise, 2nd call to OnConnected() may quit the message loop instead of OnTestSignal(). FWIW, the flakiness was introduced in crrev.com/111423 BUG=106796, 107301 TEST=confirm the test no longer fails by: while true; do out/Release/dbus_unittests --gtest_filter=EndToEndAsyncTest.TestSignal || break ; done Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M dbus/end_to_end_async_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
9 years ago (2011-12-13 04:54:37 UTC) #1
hashimoto
lgtm
9 years ago (2011-12-13 05:01:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/8907010/1
9 years ago (2011-12-13 15:07:53 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-13 17:08:44 UTC) #4
Change committed as 114223

Powered by Google App Engine
This is Rietveld 408576698