Issue 8907008: Enable the status area and make it visible on login.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8907008: Enable the status area and make it visible on login. (Closed)

Created:
9 years ago by stevenjb

Modified:
9 years ago

Reviewers:
Nikita (slow), oshima

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable the status area and make it visible on login. Change-Id: I02b3329104f9c54580143595abfebff5079eb84a BUG=107028, 107242 TEST=See issue. Make sure status buttons are correctly enabled from the login screen and once logged in, and that clicking on them during login does not crash or cause any bad behavior. Also check with the screen locker. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114509

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/login/login_utils.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

stevenjb

If you are OK with this approach, please click on the "commit" button, otherwise send ...

9 years ago (2011-12-13 02:22:50 UTC) #1

stevenjb

Oshima, can you maybe take a quick look at this? It's blocking any testing of ...

9 years ago (2011-12-14 17:39:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/8907008/1

9 years ago (2011-12-14 20:55:17 UTC) #4

Nikita (slow)

9 years ago (2011-12-15 08:03:51 UTC) #6

lgtm

Neat fix. We're indeed disabling status area during sign in.
In case of non-Aura we were relying on the fact that status area is recreated so
is enabled / visible.

Expand Messages | Collapse Messages