Add support for new scroll valuators coming from CMT

CMT can now generate motion events w/ valuators instead of a sequence of button events. This supports them

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114660

[Ben Goodger (Google), 2011-12-14 19:01:38]

http://codereview.chromium.org/8907005/diff/14001/ui/base/events.h
File ui/base/events.h (right):

http://codereview.chromium.org/8907005/diff/14001/ui/base/events.h#newcode115
ui/base/events.h:115: UI_EXPORT bool GetScrollOffsets(const base::NativeEvent&
native_event,
Offset from what?

http://codereview.chromium.org/8907005/diff/14001/ui/base/x/scroll_factory.h
File ui/base/x/scroll_factory.h (right):

http://codereview.chromium.org/8907005/diff/14001/ui/base/x/scroll_factory.h#...
ui/base/x/scroll_factory.h:37: // Requirement for Signleton
nit: I believe your type definitions have to go before the ctors/other
functions.

[DaveMoore, 2011-12-14 21:26:04]

http://codereview.chromium.org/8907005/diff/14001/ui/base/events.h
File ui/base/events.h (right):

http://codereview.chromium.org/8907005/diff/14001/ui/base/events.h#newcode115
ui/base/events.h:115: UI_EXPORT bool GetScrollOffsets(const base::NativeEvent&
native_event,
Scrolls are always deltas. I can use a different word if you like
Distances, Deltas, Amounts, Offsets

On 2011/12/14 19:01:39, Ben Goodger (Google) wrote:
> Offset from what?

http://codereview.chromium.org/8907005/diff/14001/ui/base/x/scroll_factory.h
File ui/base/x/scroll_factory.h (right):

http://codereview.chromium.org/8907005/diff/14001/ui/base/x/scroll_factory.h#...
ui/base/x/scroll_factory.h:37: // Requirement for Signleton
On 2011/12/14 19:01:39, Ben Goodger (Google) wrote:
> nit: I believe your type definitions have to go before the ctors/other
> functions.

Done.

[Ben Goodger (Google), 2011-12-14 21:41:52]

On Wed, Dec 14, 2011 at 1:26 PM, <davemoore@chromium.org> wrote:

>
>
http://codereview.chromium.**org/8907005/diff/14001/ui/**base/events.h<http:/...
> File ui/base/events.h (right):
>
> http://codereview.chromium.**org/8907005/diff/14001/ui/**
>
base/events.h#newcode115<http://codereview.chromium.org/8907005/diff/14001/ui/base/events.h#newcode115>
> ui/base/events.h:115: UI_EXPORT bool GetScrollOffsets(const
> base::NativeEvent& native_event,
> Scrolls are always deltas. I can use a different word if you like
> Distances, Deltas, Amounts, Offsets


Can you add the definition to a comment here?

-Ben

[Daniel Erat, 2011-12-14 21:49:07]

lgtm

http://codereview.chromium.org/8907005/diff/1018/ui/base/events.h
File ui/base/events.h (right):

http://codereview.chromium.org/8907005/diff/1018/ui/base/events.h#newcode75
ui/base/events.h:75: UI_EXPORT void UpdateDeviceList();
nit: need empty windows implementation

http://codereview.chromium.org/8907005/diff/1018/ui/base/x/events_x.cc
File ui/base/x/events_x.cc (right):

http://codereview.chromium.org/8907005/diff/1018/ui/base/x/events_x.cc#newcode23
ui/base/x/events_x.cc:23: #define AXIS_LABEL_PROP_REL_HWHEEL      "Rel Horiz
Wheel"
nit: just one space between symbol name and string?

http://codereview.chromium.org/8907005/diff/1018/ui/base/x/events_x.cc#newcode53
ui/base/x/events_x.cc:53: int count;
nit: initialize to 0

http://codereview.chromium.org/8907005/diff/1018/ui/base/x/events_x.cc#newcod...
ui/base/x/events_x.cc:100: // valuators. Also returns the offsets. |x_offset|
and |y_offset| can be
nit: add ')' after 'valuators'

either initialize |x_offset| and |y_offset| to 0 at the beginning or state that
they'll be untouched if this isn't a scroll event?

http://codereview.chromium.org/8907005/diff/1018/ui/views/events/event_aura.cc
File ui/views/events/event_aura.cc (right):

http://codereview.chromium.org/8907005/diff/1018/ui/views/events/event_aura.c...
ui/views/events/event_aura.cc:64:
ui::GetScrollOffsets(native_event->native_event(), &x_offset_, &y_offset_);
nit: worthwhile CHECK-ing that this returns true?

[DaveMoore, 2011-12-15 17:07:15]

Ben: I had already added the comment you suggested.

http://codereview.chromium.org/8907005/diff/1018/ui/base/events.h
File ui/base/events.h (right):

http://codereview.chromium.org/8907005/diff/1018/ui/base/events.h#newcode75
ui/base/events.h:75: UI_EXPORT void UpdateDeviceList();
On 2011/12/14 21:49:07, Daniel Erat wrote:
> nit: need empty windows implementation

Done.

http://codereview.chromium.org/8907005/diff/1018/ui/base/x/events_x.cc
File ui/base/x/events_x.cc (right):

http://codereview.chromium.org/8907005/diff/1018/ui/base/x/events_x.cc#newcode23
ui/base/x/events_x.cc:23: #define AXIS_LABEL_PROP_REL_HWHEEL      "Rel Horiz
Wheel"
On 2011/12/14 21:49:07, Daniel Erat wrote:
> nit: just one space between symbol name and string?

Done.

http://codereview.chromium.org/8907005/diff/1018/ui/base/x/events_x.cc#newcode53
ui/base/x/events_x.cc:53: int count;
On 2011/12/14 21:49:07, Daniel Erat wrote:
> nit: initialize to 0

Done.

http://codereview.chromium.org/8907005/diff/1018/ui/base/x/events_x.cc#newcod...
ui/base/x/events_x.cc:100: // valuators. Also returns the offsets. |x_offset|
and |y_offset| can be
On 2011/12/14 21:49:07, Daniel Erat wrote:
> nit: add ')' after 'valuators'
> 
> either initialize |x_offset| and |y_offset| to 0 at the beginning or state
that
> they'll be untouched if this isn't a scroll event?

Done.

http://codereview.chromium.org/8907005/diff/1018/ui/views/events/event_aura.cc
File ui/views/events/event_aura.cc (right):

http://codereview.chromium.org/8907005/diff/1018/ui/views/events/event_aura.c...
ui/views/events/event_aura.cc:64:
ui::GetScrollOffsets(native_event->native_event(), &x_offset_, &y_offset_);
On 2011/12/14 21:49:07, Daniel Erat wrote:
> nit: worthwhile CHECK-ing that this returns true?

Done.

[Ben Goodger (Google), 2011-12-15 17:44:49]

lgtm