Update avatar bubble if profile info changes

chrome/browser/ui/views/avatar_menu_bubble_view.cc

Index: chrome/browser/ui/views/avatar_menu_bubble_view.cc
diff --git a/chrome/browser/ui/views/avatar_menu_bubble_view.cc b/chrome/browser/ui/views/avatar_menu_bubble_view.cc
index 9f1b0816bbb73414ca795ccb99911cccdf942864..594827121fa0838491d88b244e4655dc83252f6e 100644
--- a/chrome/browser/ui/views/avatar_menu_bubble_view.cc
+++ b/chrome/browser/ui/views/avatar_menu_bubble_view.cc
@@ -351,14 +351,15 @@ AvatarMenuBubbleView::AvatarMenuBubbleView(
   avatar_menu_model_.reset(new AvatarMenuModel(
       &g_browser_process->profile_manager()->GetProfileInfoCache(),
       this, browser_));
-  // Build the menu for the first time.
-  OnAvatarMenuModelChanged(avatar_menu_model_.get());
 }
 
 AvatarMenuBubbleView::~AvatarMenuBubbleView() {
 }
 
 gfx::Size AvatarMenuBubbleView::GetPreferredSize() {
+  if (!add_profile_link_)
+    return gfx::Size();
+
   int max_width = 0;
   int total_height = 0;
   for (size_t i = 0; i < item_views_.size(); ++i) {
@@ -431,6 +432,16 @@ bool AvatarMenuBubbleView::AcceleratorPressed(
   return true;
 }
 
+void AvatarMenuBubbleView::ViewHierarchyChanged(bool is_add,
+                                                views::View* parent,
+                                                views::View* child) {
+  // Build the menu for the first time.
+  if (!add_profile_link_ && is_add && child == this)

[msw, 2011/12/13 03:20:23]

I don't think |this| will be added as a child more than once. Is there a reason
why you're checking whether |add_profile_link_| has been initialized?

[sail, 2011/12/13 19:28:47]

It doesn't make sense to call OnAvatarMenuModelChanged() more than once.
add_profile_link_ will only be NULL if OnAvatarMenuModelChanged() has not been
called yet. From what I understand if the view removed and added again then
|this| will be added as a child again.

[msw, 2011/12/13 21:15:06]

I'd just DCHECK(!add_profile_link_) in OnAvatarMenuModelChanged, because the
same BubbleDelegateView shouldn't be removed and re-added in practice. But I
guess this extra resilience might be good for merging.

+    OnAvatarMenuModelChanged(avatar_menu_model_.get());
+
+  views::BubbleDelegateView::ViewHierarchyChanged(is_add, parent, child);
+}
+
 void AvatarMenuBubbleView::ButtonPressed(views::Button* sender,
                                          const views::Event& event) {
   for (size_t i = 0; i < item_views_.size(); ++i) {
@@ -497,5 +508,7 @@ void AvatarMenuBubbleView::OnAvatarMenuModelChanged(
   add_profile_link_->SetEnabledColor(SkColorSetRGB(0xe3, 0xed, 0xf6));
   AddChildView(add_profile_link_);
 
-  PreferredSizeChanged();
+  // If the bubble has already been shown then resize and reposition the bubble.
+  Layout();
+  SizeToContents();
 }