Update avatar bubble if profile info changes

chrome/browser/ui/views/avatar_menu_bubble_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/avatar_menu_bubble_view.h"
 
 #include <algorithm>
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 479 matching lines @@
   AddChildView(separator_);
 
   add_profile_link_ = new views::Link(
       l10n_util::GetStringUTF16(IDS_PROFILES_CREATE_NEW_PROFILE_LINK));
   add_profile_link_->set_listener(this);
   add_profile_link_->SetHorizontalAlignment(views::Label::ALIGN_LEFT);
   add_profile_link_->SetBackgroundColor(color());
   add_profile_link_->SetEnabledColor(SkColorSetRGB(0xe3, 0xed, 0xf6));
   AddChildView(add_profile_link_);
 
-  PreferredSizeChanged();
+  // If the bubble has already been shown then resize and reposition the bubble.
+  if (GetWidget()) {

[Peter Kasting, 2011/12/12 21:43:43]

This is actually kind of worrisome.  If we can reach here without GetWidget()
being true that means that we could  probably leak the views created above. 
Normally we only create and add child views in response to ourselves being added
to a view hierarchy, i.e. in an OnViewHierarchyChanged() override.  This class
does it in the constructor instead which is bad form because it means whoever
constructs this class needs to ensure it gets properly destroyed if it is never
added to a view hierarchy.

If we fix this problem then perhaps the original bug goes away as well?

[sail, 2011/12/13 01:58:34]

Done.
I still needed the Layout/SizeToContents() call to get the button to reposition.

+    Layout();
+    SizeToContents();
+  }
 }