Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 8905028: Forward declare WebIntentServiceData in extension.h. (Closed)

Created:
9 years ago by Mihai Parparita -not on Chrome
Modified:
9 years ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Forward declare WebIntentServiceData in extension.h. R=groby@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114180

Patch Set 1 #

Patch Set 2 : WebIntentServiceData is a struct. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/common/extensions/extension.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_manifests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mihai Parparita -not on Chrome
9 years ago (2011-12-13 01:16:39 UTC) #1
groby-ooo-7-16
lgtm
9 years ago (2011-12-13 01:50:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/8905028/4001
9 years ago (2011-12-13 02:37:52 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-13 04:26:19 UTC) #4
Change committed as 114180

Powered by Google App Engine
This is Rietveld 408576698