Issue 8905025: ChromeOS Mouse settings.

Issue 8905025: ChromeOS Mouse settings. (Closed)

Created:
9 years ago by achuithb

Modified:
9 years ago

Reviewers:
xiyuan, James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

ChromeOS Mouse settings. Split out pointer, touchpad and mouse settings. BUG=chromium-os:22305 TEST=chrome://settings/system should have separate pointer, touchpad and mouse settings. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114600

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2

Patch Set 6 : slider-value is now pointer-value #

Patch Set 7 : replace radio button with checkbox per Kuscher #

Patch Set 8 : remove debug stmts #

Patch Set 9 : system_options_handler2.cc #

Patch Set 10 : debug stmts #

Total comments: 2

Patch Set 11 : merge options changes into options2 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -35 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 2 3 4 5 6 7	3 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/preferences.h	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/preferences.cc	View	1 2 3 4 5 6 7	3 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/system/touchpad_settings.h	View	1 2 3 4 5 6 7	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/system/touchpad_settings.cc	View	1 2 3 4 5 6 7 9	3 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos/system_options.html	View	1 2 3 4 5 6 7 9	4 chunks	+28 lines, -13 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos/system_options_page.css	View	1 2 3 4 5 6 7	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/options2/chromeos/system_options.html	View	1 2 3 4 5 6 7 8 9 10	4 chunks	+28 lines, -13 lines	0 comments	Download
M	chrome/browser/resources/options2/chromeos/system_options_page.css	View	1 2 3 4 5 6 7 8 9 10	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/system_options_handler.cc	View	1 2 3 4 5 6 7	3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/system_options_handler.cc	View	1 2 3 4 5 6 7 8 9 10	3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/common/pref_names.h	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 2 3 4 5 6 7	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 14 (0 generated)

Expand Messages | Collapse Messages

achuithb

Xiyuan: this CL deals only with the UI part of the bug. I need to ...

9 years ago (2011-12-13 21:26:41 UTC) #1

xiyuan

lgtm http://codereview.chromium.org/8905025/diff/10002/chrome/browser/resources/options/chromeos/system_options.html File chrome/browser/resources/options/chromeos/system_options.html (right): http://codereview.chromium.org/8905025/diff/10002/chrome/browser/resources/options/chromeos/system_options.html#newcode38 chrome/browser/resources/options/chromeos/system_options.html:38: <div id="slider-value"> nit: slider-value sounds too generic, how ...

9 years ago (2011-12-13 21:55:54 UTC) #2

achuithb

Thanks for the review! http://codereview.chromium.org/8905025/diff/10002/chrome/browser/resources/options/chromeos/system_options.html File chrome/browser/resources/options/chromeos/system_options.html (right): http://codereview.chromium.org/8905025/diff/10002/chrome/browser/resources/options/chromeos/system_options.html#newcode38 chrome/browser/resources/options/chromeos/system_options.html:38: <div id="slider-value"> On 2011/12/13 21:55:54, ...

9 years ago (2011-12-13 21:59:41 UTC) #3

achuithb

PTAL, Xiyuan. I've switched from using radio buttons to using a checkbox per PMs.

9 years ago (2011-12-15 00:22:29 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/8905025/24007

9 years ago (2011-12-15 02:25:20 UTC) #6

commit-bot: I haz the power

Presubmit check for 8905025-24007 failed and returned exit status 1. Running presubmit commit checks ...

9 years ago (2011-12-15 02:25:27 UTC) #7

achuithb

James: Need owner LGTM for system_options_page.css, system_options.html

9 years ago (2011-12-15 02:29:00 UTC) #8

James Hawkins

Please apply the resources/options part of the patch to resources/options2. http://codereview.chromium.org/8905025/diff/24007/chrome/browser/ui/webui/options/chromeos/system_options_handler.cc File chrome/browser/ui/webui/options/chromeos/system_options_handler.cc (left): http://codereview.chromium.org/8905025/diff/24007/chrome/browser/ui/webui/options/chromeos/system_options_handler.cc#oldcode47 ...

9 years ago (2011-12-15 02:31:30 UTC) #9

achuithb

On 2011/12/15 02:31:30, James Hawkins wrote: > Please apply the resources/options part of the patch ...

9 years ago (2011-12-15 02:40:00 UTC) #10

achuithb

PTAL http://codereview.chromium.org/8905025/diff/24007/chrome/browser/ui/webui/options/chromeos/system_options_handler.cc File chrome/browser/ui/webui/options/chromeos/system_options_handler.cc (left): http://codereview.chromium.org/8905025/diff/24007/chrome/browser/ui/webui/options/chromeos/system_options_handler.cc#oldcode47 chrome/browser/ui/webui/options/chromeos/system_options_handler.cc:47: On 2011/12/15 02:31:30, James Hawkins wrote: > Add ...

9 years ago (2011-12-15 02:40:10 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/8905025/26005

9 years ago (2011-12-15 04:02:16 UTC) #13

Change committed as 114600

Expand Messages | Collapse Messages