Dartest CL - Please review

compiler/java/com/google/dart/compiler/DartCompiler.java

Index: compiler/java/com/google/dart/compiler/DartCompiler.java
===================================================================
--- compiler/java/com/google/dart/compiler/DartCompiler.java	(revision 2358)
+++ compiler/java/com/google/dart/compiler/DartCompiler.java	(working copy)
@@ -11,6 +11,7 @@
 import com.google.dart.compiler.CommandLineOptions.CompilerOptions;
 import com.google.dart.compiler.LibraryDeps.Dependency;
 import com.google.dart.compiler.UnitTestBatchRunner.Invocation;
+import com.google.dart.compiler.ast.CoverageInstrumenter;
 import com.google.dart.compiler.ast.DartDirective;
 import com.google.dart.compiler.ast.DartLibraryDirective;
 import com.google.dart.compiler.ast.DartNode;
@@ -682,6 +683,10 @@
 
         // Dump the compiler parse tree if dump format is set in arguments
         BaseASTWriter astWriter = ASTWriterFactory.create(config);
+        
+        // Coverage instrumenter
+        CoverageInstrumenter coverageInstrumenter = CoverageInstrumenter.createInstance(config);
+        coverageInstrumenter.process(libraries);

[zundel, 2011/12/16 20:49:05]

nit.  you have an internal loop that duplicates the nested for loops below.  You
could move process() into the for loop and have it accept a unit as input.

Or you could make the instrumenter a part of the Normalizer.

 
         // The two following for loops can be parallelized.
         for (LibraryUnit lib : libraries.values()) {