Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 8905010: Update comment on IOThread to point people to the right place if they (Closed)

Created:
9 years ago by Jói
Modified:
9 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Visibility:
Public.

Description

Update comment on IOThread to point people to the right place if they want some of the functionality that used to be there. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114288

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment." #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/io_thread.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jói
9 years ago (2011-12-12 17:08:13 UTC) #1
Avi (use Gerrit)
lgtm http://codereview.chromium.org/8905010/diff/1/chrome/browser/io_thread.h File chrome/browser/io_thread.h (right): http://codereview.chromium.org/8905010/diff/1/chrome/browser/io_thread.h#newcode53 chrome/browser/io_thread.h:53: // If you are looking to e.g. post ...
9 years ago (2011-12-13 14:56:31 UTC) #2
Jói
Thanks Avi! http://codereview.chromium.org/8905010/diff/1/chrome/browser/io_thread.h File chrome/browser/io_thread.h (right): http://codereview.chromium.org/8905010/diff/1/chrome/browser/io_thread.h#newcode53 chrome/browser/io_thread.h:53: // If you are looking to e.g. ...
9 years ago (2011-12-13 15:09:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8905010/5001
9 years ago (2011-12-13 15:10:14 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-13 16:10:04 UTC) #5
Try job failure for 8905010-5001 (retry) on win_rel for step "update".
It's a second try, previously, steps "browser_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698