Issue 8905008: Include missing include.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8905008: Include missing include. (Closed)

Created:
9 years ago by Avi (use Gerrit)

Modified:
9 years ago

Reviewers:
Jói

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Include missing include. BUG=105872 TEST=aura builder greens Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114018

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/ui/views/aura/app_list_window.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

Pulling out the include for TC from TCW.h broke a ton of places that used ...

9 years ago (2011-12-12 15:39:36 UTC) #1

Jói

9 years ago (2011-12-12 15:41:49 UTC) #2

LGTM

On Mon, Dec 12, 2011 at 3:39 PM,  <avi@chromium.org> wrote:
> Reviewers: Jói,
>
> Message:
> Pulling out the include for TC from TCW.h broke a ton of places that used TC
> without ICYU. Fixing a build break from that.
>
> Description:
> Include missing include.
>
> BUG=105872
> TEST=aura builder greens
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114018
>
> Please review this at http://codereview.chromium.org/8905008/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/ui/views/aura/app_list_window.cc
>
>
> Index: chrome/browser/ui/views/aura/app_list_window.cc
> diff --git a/chrome/browser/ui/views/aura/app_list_window.cc
> b/chrome/browser/ui/views/aura/app_list_window.cc
> index
>
8d4f2f472915c99c53b67dd9fad54c1282bf9237..036790ef55718af17c6a8fa127c09da7744ed7ca
> 100644
> --- a/chrome/browser/ui/views/aura/app_list_window.cc
> +++ b/chrome/browser/ui/views/aura/app_list_window.cc
> @@ -10,6 +10,7 @@
>  #include "chrome/common/url_constants.h"
>  #include "content/browser/renderer_host/render_view_host.h"
>  #include "content/browser/renderer_host/render_widget_host_view.h"
> +#include "content/browser/tab_contents/tab_contents.h"
>  #include "ui/aura_shell/shell.h"
>  #include "ui/views/widget/widget.h"
>
>
>

Expand Messages | Collapse Messages