Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 8905007: Put irt and untrusted TC dependencies behind a flag. (Closed)

Created:
9 years ago by robertm
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Put irt and untrusted TC dependencies behind a flag. This helps with arm development where the PNaCl hook up will take a while. Also: * split ppapi_proxy.gyp into trusted and untrusted parts. * enable nacl for arm when *not* targeting chromeos Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114438

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -105 lines) Patch
M build/common.gypi View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M chrome/chrome_exe.gypi View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl.gypi View 1 2 3 4 5 6 1 chunk +7 lines, -1 line 0 comments Download
M ppapi/native_client/native_client.gyp View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp View 1 2 3 1 chunk +2 lines, -99 lines 0 comments Download
A ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy_untrusted.gyp View 1 chunk +108 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
robertm
PTAL this where I would like to go not sure whether his can be done ...
9 years ago (2011-12-12 20:04:46 UTC) #1
noelallen_use_chromium
nice. LGTM http://codereview.chromium.org/8905007/diff/4001/ppapi/native_client/native_client.gyp File ppapi/native_client/native_client.gyp (right): http://codereview.chromium.org/8905007/diff/4001/ppapi/native_client/native_client.gyp#newcode9 ppapi/native_client/native_client.gyp:9: 'targets': [], This actually works? I could ...
9 years ago (2011-12-12 22:16:29 UTC) #2
Mark Mentovai
LGTM
9 years ago (2011-12-12 22:17:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertm@google.com/8905007/16001
9 years ago (2011-12-13 19:02:30 UTC) #4
commit-bot: I haz the power
Try job failure for 8905007-16001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-13 20:03:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertm@google.com/8905007/16001
9 years ago (2011-12-13 22:30:33 UTC) #6
commit-bot: I haz the power
Try job failure for 8905007-16001 (retry) on linux_rel for step "ui_tests". It's a second try, ...
9 years ago (2011-12-13 23:42:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertm@google.com/8905007/16001
9 years ago (2011-12-14 15:30:33 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-14 16:32:09 UTC) #9
Change committed as 114438

Powered by Google App Engine
This is Rietveld 408576698