Issue 8905006: Add --dart-flags and --disable-dart command line switches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8905006: Add --dart-flags and --disable-dart command line switches. (Closed)

Created:
9 years ago by podivilov

Modified:
9 years ago

Reviewers:
darin (slow to review), jam, Avi (use Gerrit)

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, brettw-cc_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, pam+watch_chromium.org, antonm, vsm

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add --dart-flags and --disable-dart command line switches. R=darin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115707

Patch Set 1 #

Patch Set 2 : . #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -0 lines)			Patch
M	build/common.gypi	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/view_messages.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/public/common/content_switches.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/renderer/render_process_impl.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_main.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_switches.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

podivilov

Not hiding everything behind WEBKIT_USING_DART to make the code nicer. Please let me know if ...

9 years ago (2011-12-12 18:59:37 UTC) #1

podivilov

On 2011/12/12 19:21:14, darin wrote: > OK, LGTM Looks like I need another LGTM from ...

9 years ago (2011-12-19 16:50:31 UTC) #3

content/public lgtm

Expand Messages | Collapse Messages