Fix profile name resetting to GAIA name

Fix profile name resetting to GAIA name

If the user had a custom profile name then clicking on "Edit profile" would reset the name to their GAIA name.

The problem was that we were incorrectly detecting that the user had changed their profile picture to their GAIA picture. Clicking on the GAIA picture causes us to set the profile name to the GAIA name.

Fix was to only send profile picture changed events if the user actually changed their profile picture.

BUG=106382
TEST=Reproduced the bug. Applied my fix and verified that it no longer reproduced.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114073

[binji, 2011-12-12 18:44:51]

http://codereview.chromium.org/8905001/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/manage_profile_overlay.js (right):

http://codereview.chromium.org/8905001/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/manage_profile_overlay.js:206:
this.iconGridSelectedURL_ = iconURL;
Shouldn't this be set, even if iconURL is null?

[sail, 2011-12-12 18:53:57]

http://codereview.chromium.org/8905001/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/manage_profile_overlay.js (right):

http://codereview.chromium.org/8905001/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/manage_profile_overlay.js:206:
this.iconGridSelectedURL_ = iconURL;
On 2011/12/12 18:44:52, binji wrote:
> Shouldn't this be set, even if iconURL is null?

The iconURL becomes NULL when the overlay is closed. If we update
iconGridSelectedURL_ here then we'll think the selection has been changed even
when it actually hasn't.

[binji, 2011-12-12 18:55:04]

OK, lgtm!

[commit-bot: I haz the power, 2011-12-12 19:24:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8905001/2001

[commit-bot: I haz the power, 2011-12-12 19:25:01]

Presubmit check for 8905001-2001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/resources/options/manage_profile_overlay.js

[sail, 2011-12-12 19:25:44]

jhawkins for OWNERS approval

[James Hawkins, 2011-12-12 19:30:13]

LGTM

[commit-bot: I haz the power, 2011-12-12 19:45:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8905001/2001

[commit-bot: I haz the power, 2011-12-12 20:43:41]

Change committed as 114073