Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 89003: When env.Replace() is getting called with a list of Nodes, use a slice to... (Closed)

Created:
11 years, 8 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, Craig Schlenter
Visibility:
Public.

Description

When env.Replace() is getting called with a list of Nodes, use a slice to replace the old list element with the new list. This keeps the list of files flattened and lets the later Builder calls remove the file names with non-linkable/non-compilable suffixes (.h) from the list. Add .gperf to the list of non-{compil,link}able suffixes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M site_scons/site_tools/chromium_builders.py View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sgk
This lets the builder calls like ChromeProgram() and ChromeStaticLibrary() take .h and .gperf out of ...
11 years, 8 months ago (2009-04-20 21:17:27 UTC) #1
Mark Mentovai
11 years, 8 months ago (2009-04-20 21:21:55 UTC) #2
Looks good.

Powered by Google App Engine
This is Rietveld 408576698