Issue 8900002: linux: Disable Canvas2dAllowed, it times out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8900002: linux: Disable Canvas2dAllowed, it times out. (Closed)

Created:
9 years ago by Nico

Modified:
9 years ago

Reviewers:
joi

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

linux: Disable Canvas2dAllowed, it times out. BUG=104142 TEST=none TBR=joi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113959

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/gpu/gpu_feature_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

joi

9 years ago (2011-12-12 09:06:26 UTC) #2

LGTM

Noted about the timeout and using DISABLED_, IIRC it was a pretty
hectic day when I marked this flaky so I didn't think :)

Cheers,
Jói


On Sat, Dec 10, 2011 at 8:20 PM,  <thakis@chromium.org> wrote:
> Reviewers: joi,
>
> Description:
> linux: Disable Canvas2dAllowed, it times out.
>
> BUG=104142
> TEST=none
> TBR=joi
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113959
>
> Please review this at http://codereview.chromium.org/8900002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/test/gpu/gpu_feature_browsertest.cc
>
>
> Index: chrome/test/gpu/gpu_feature_browsertest.cc
> diff --git a/chrome/test/gpu/gpu_feature_browsertest.cc
> b/chrome/test/gpu/gpu_feature_browsertest.cc
> index
>
58bb9949a44e494240254d4ac414947d545d915d..38198a15c55a2e64f6fe0e81f2db674ea9566bba
> 100644
> --- a/chrome/test/gpu/gpu_feature_browsertest.cc
> +++ b/chrome/test/gpu/gpu_feature_browsertest.cc
> @@ -190,7 +190,7 @@ IN_PROC_BROWSER_TEST_F(GpuFeatureTest, WebGLBlocked) {
>
>  #if defined(OS_LINUX)
>  // http://crbug.com/104142
> -#define Canvas2DAllowed FLAKY_Canvas2DAllowed
> +#define Canvas2DAllowed DISABLED_Canvas2DAllowed
>  #endif
>  IN_PROC_BROWSER_TEST_F(GpuFeatureTest, Canvas2DAllowed) {
>   GpuFeatureFlags flags =
> GpuDataManager::GetInstance()->GetGpuFeatureFlags();
>
>

Expand Messages | Collapse Messages