Issue 8899021: Merge 113936 - Don't close ExtensionPopups on child window focus (Win, non-Aura).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8899021: Merge 113936 - Don't close ExtensionPopups on child window focus (Win, non-Aura). (Closed)

Created:
9 years ago by msw

Modified:
9 years ago

Reviewers:
msw

CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/branches/963/src/

Visibility:
Public.

More Reviews

Description

Merge 113936 - Don't close ExtensionPopups on child window focus (Win, non-Aura). Fixes crash on JS dialog popups from the extension bubbles. Check for child HWND in WidgetFocusChangeListener::OnNativeFocusChange. Code from BubbleWidget in browser_bubble_win.cc (crrev.com/112278) See Issue 106958 for Aura, the dialog&bubble close early without crashing. BUG=106723, 106958 TEST=The js alert extension attached to the issue doesn't crash, popup works on non-aura. Review URL: http://codereview.chromium.org/8879045 TBR=msw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113961

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -3 lines)			Patch
M	chrome/browser/ui/views/extensions/extension_popup.h	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_popup.cc	View	3 chunks	+29 lines, -0 lines	0 comments	Download
M	ui/views/focus/widget_focus_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages