Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/tab_contents/background_contents.h

Issue 8899019: Handle AddNewContents in BackgroundContents so we can open windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/tab_contents/background_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/background_contents.h
diff --git a/chrome/browser/tab_contents/background_contents.h b/chrome/browser/tab_contents/background_contents.h
index 05900c065f2cc40b6301dfee2b858a4e0eb3433d..cdcee2605f54b900b1742f8249e11d867cb3f905 100644
--- a/chrome/browser/tab_contents/background_contents.h
+++ b/chrome/browser/tab_contents/background_contents.h
@@ -25,7 +25,7 @@ class BackgroundContents : public TabContentsDelegate,
public:
class Delegate {
public:
- // Called by ShowCreatedWindow. Asks the delegate to attach the opened
+ // Called by AddNewContents(). Asks the delegate to attach the opened
// TabContents to a suitable container (e.g. browser) or to show it if it's
// a popup window.
virtual void AddTabContents(TabContents* new_contents,
@@ -49,6 +49,11 @@ class BackgroundContents : public TabContentsDelegate,
virtual void CloseContents(TabContents* source) OVERRIDE;
virtual bool ShouldSuppressDialogs() OVERRIDE;
virtual void DidNavigateMainFramePostCommit(TabContents* tab) OVERRIDE;
+ virtual void AddNewContents(TabContents* source,
+ TabContents* new_contents,
+ WindowOpenDisposition disposition,
+ const gfx::Rect& initial_pos,
+ bool user_gesture) OVERRIDE;
// TabContentsObserver implementation:
virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE;
« no previous file with comments | « no previous file | chrome/browser/tab_contents/background_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698