Handle AddNewContents in BackgroundContents so we can open windows.

Handle AddNewContents in BackgroundContents so we can open windows.

window.open() in BackgroundContents was failing in M17 because we were no longer
hooking ShowCreatedWindow() and forwarding the request to our delegate.

Now that BackgroundContents wraps a real TabContents, we now hook AddNewContents()
and pass it off to our Delegate to open a new window.

BUG=105992
TEST=instructions in bug.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113955

[Andrew T Wilson (Slow), 2011-12-10 01:07:45]

Please take a look.

[jam, 2011-12-10 01:42:36]

lgtm!

[jam, 2011-12-10 01:43:00]

can we add a browser test, based on the repro case, to avoid this regressing
again? (doesn't have to be in this cl)

[Andrew T Wilson (Slow), 2011-12-10 02:25:17]

On 2011/12/10 01:43:00, John Abd-El-Malek wrote:
> can we add a browser test, based on the repro case, to avoid this regressing
> again? (doesn't have to be in this cl)
I thought about this, but it seems a bit tricky, as ordinarily opening a window
like this would hit the popup blocker, wouldn't it?

Maybe we can set the command line flags to disable the popup blocker before the
test...

[commit-bot: I haz the power, 2011-12-10 16:30:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/atwilson@chromium.org/8899019/1

[jam, 2011-12-10 16:56:39]

On Sat, Dec 10, 2011 at 4:25 AM, <atwilson@chromium.org> wrote:

> On 2011/12/10 01:43:00, John Abd-El-Malek wrote:
>
>> can we add a browser test, based on the repro case, to avoid this
>> regressing
>> again? (doesn't have to be in this cl)
>>
> I thought about this, but it seems a bit tricky, as ordinarily opening a
> window
> like this would hit the popup blocker, wouldn't it?
>
> Maybe we can set the command line flags to disable the popup blocker
> before the
> test...
>

yep, i've seen this done in a test before

>
>
http://codereview.chromium.**org/8899019/<http://codereview.chromium.org/8899...
>

[commit-bot: I haz the power, 2011-12-10 17:39:50]

Change committed as 113955