Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 8899015: Implement platform-independent DrawGlyphs for Flash. (Closed)

Created:
9 years ago by brettw
Modified:
9 years ago
Reviewers:
yzshen1
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Implement platform-independent DrawGlyphs for Flash. This code was platform independent so could just be copied over into the platform independent file with no changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114076

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -137 lines) Patch
M webkit/glue/webkit_glue.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_flash_impl.h View 1 chunk +0 lines, -16 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_impl.cc View 4 chunks +103 lines, -1 line 0 comments Download
D webkit/plugins/ppapi/ppb_flash_impl_linux.cc View 1 chunk +0 lines, -119 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
9 years ago (2011-12-09 23:51:42 UTC) #1
yzshen1
lgtm
9 years ago (2011-12-10 00:03:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/8899015/1
9 years ago (2011-12-10 17:05:41 UTC) #3
commit-bot: I haz the power
Presubmit check for 8899015-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-10 17:05:44 UTC) #4
M-A Ruel
On 2011/12/10 17:05:44, I haz the power (commit-bot) wrote: > Missing LGTM from an OWNER ...
9 years ago (2011-12-12 21:14:08 UTC) #5
brettw
9 years ago (2011-12-12 21:18:40 UTC) #6
On Mon, Dec 12, 2011 at 1:14 PM,  <maruel@chromium.org> wrote:
> On 2011/12/10 17:05:44, I haz the power (commit-bot) wrote:
>>
>> Missing LGTM from an OWNER for: webkit/glue/webkit_glue.gypi
>
>
> If you want to work around this, you can use:
> TBR=foo
> in your CL, disabling the owners check so you can use the CQ properly.

Ah. I really just need to move the source files which is why I haven't
done a better job with the gyp files.

Brett

Powered by Google App Engine
This is Rietveld 408576698