Issue 8899011: Virtual Me2Me: Redirect stdin of Xsession to /dev/null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8899011: Virtual Me2Me: Redirect stdin of Xsession to /dev/null. (Closed)

Created:
9 years ago by Lambros

Modified:
9 years ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Virtual Me2Me: Redirect stdin of Xsession to /dev/null. This fixes the problem of the Me2Me process being stopped when running as a shell background job. BUG=106935 TEST=Follow repro steps Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114238

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	remoting/tools/me2me_virtual_host.py	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jamie

LGTM, but do we know what's reading from stdin and why? How is it going ...

9 years ago (2011-12-09 22:33:39 UTC) #2

Lambros

9 years ago (2011-12-13 18:37:24 UTC) #3

On 2011/12/09 22:33:39, Jamie wrote:
> LGTM, but do we know what's reading from stdin and why? How is it going to
> behave if we redirect it?
Can't tell for sure, but looks like it might be /usr/bin/x-session-manager
(which symlinks to gnome-session).  And the system's gnome-session has its stdin
pointing at /dev/null :)

Expand Messages | Collapse Messages