[cros] Add --stub-cros-settings option for testing.

chrome/browser/chromeos/cros_settings.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/cros_settings.h"
 
+#include "base/bind.h"
+#include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/device_settings_provider.h"
+#include "chrome/browser/chromeos/stub_cros_settings_provider.h"
 #include "chrome/browser/ui/webui/options/chromeos/system_settings_provider.h"
 #include "chrome/common/chrome_notification_types.h"
+#include "chrome/common/chrome_switches.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 
 namespace chromeos {
 
 static base::LazyInstance<CrosSettings> g_cros_settings =
     LAZY_INSTANCE_INITIALIZER;
 
 CrosSettings* CrosSettings::Get() {
   // TODO(xiyaun): Use real stuff when underlying libcros is ready.
   return g_cros_settings.Pointer();
 }
 
 bool CrosSettings::IsCrosSettings(const std::string& path) {
   return StartsWithASCII(path, kCrosSettingsPrefix, true);
 }
 
-void CrosSettings::FireObservers(const char* path) {
+void CrosSettings::FireObservers(const std::string& path) {
   DCHECK(CalledOnValidThread());
-  std::string path_str(path);
   SettingsObserverMap::iterator observer_iterator =
-      settings_observers_.find(path_str);
+      settings_observers_.find(path);
   if (observer_iterator == settings_observers_.end())
     return;
 
   NotificationObserverList::Iterator it(*(observer_iterator->second));
   content::NotificationObserver* observer;
   while ((observer = it.GetNext()) != NULL) {
     observer->Observe(chrome::NOTIFICATION_SYSTEM_SETTING_CHANGED,
                       content::Source<CrosSettings>(this),
-                      content::Details<std::string>(&path_str));
+                      content::Details<const std::string>(&path));
   }
 }
 
 void CrosSettings::Set(const std::string& path, const base::Value& in_value) {
   DCHECK(CalledOnValidThread());
   CrosSettingsProvider* provider;
   provider = GetProvider(path);
   if (provider)
     provider->Set(path, in_value);
 }
@@ skipping 200 matching lines @@
 bool CrosSettings::GetList(const std::string& path,
                            const base::ListValue** out_value) const {
   DCHECK(CalledOnValidThread());
   const base::Value* value = GetPref(path);
   if (value)
     return value->GetAsList(out_value);
   return false;
 }
 
 CrosSettings::CrosSettings() {
-  AddSettingsProvider(new SystemSettingsProvider());
-  AddSettingsProvider(new DeviceSettingsProvider());
+  CrosSettingsProvider::NotifyObserversCallback notify_cb(
+      base::Bind(&CrosSettings::FireObservers,
+                 // This is safe since |this| is never deleted.
+                 base::Unretained(this)));
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kStubCrosSettings)) {
+    AddSettingsProvider(new StubCrosSettingsProvider(notify_cb));
+  }
+  AddSettingsProvider(new SystemSettingsProvider(notify_cb));

[pastarmovj, 2011/12/13 13:41:07]

You might even want to put the real providers in an else clause to avoid having
to reload them which might not work well in test environment without proper
mocking.

[Ivan Korotkov, 2011/12/13 14:46:16]

Done for Device provider (System provider is not mocked for now anyway).

+  AddSettingsProvider(new DeviceSettingsProvider(notify_cb));
 }
 
 CrosSettings::~CrosSettings() {
   STLDeleteElements(&providers_);
   STLDeleteValues(&settings_observers_);
 }
 
 }  // namespace chromeos