Add aura window as child of lock screen layer rather than setting parent to lock layer.

Add aura window as child of lock screen layer rather than setting parent to lock layer.

TBR=nkostylev@chromium.org
BUG=106473
TEST=Lock screen, observe that launcher icons are no longer visible.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113860

[saintlou, 2011-12-09 16:11:45]

lgtm

Moved nkostylev@ to TBR
LGTM

[commit-bot: I haz the power, 2011-12-09 16:12:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/8899001/1

[commit-bot: I haz the power, 2011-12-09 16:12:02]

Can't apply patch for file chrome/browser/chromeos/login/lock_window_aura.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/chromeos/login/lock_window_aura.cc
Hunk #1 FAILED at 41.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/chromeos/login/lock_window_aura.cc.rej

[commit-bot: I haz the power, 2011-12-09 16:13:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/8899001/3001

[Nikita (slow), 2011-12-09 16:41:15]

lgtm

Aha, that makes sense as we use AddChild in WebUILoginDisplayHost::LoadURL().
That was the difference between login and screen locker case.

I should have actually payed more attention to the initial CL and review it
(http://codereview.chromium.org/8711003) even though I was only cc'ed on it.

[commit-bot: I haz the power, 2011-12-09 18:24:41]

Try job failure for 8899001-3001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[flackr, 2011-12-10 15:20:44]

On 2011/12/09 16:41:15, Nikita Kostylev wrote:
> lgtm
> 
> Aha, that makes sense as we use AddChild in WebUILoginDisplayHost::LoadURL().
> That was the difference between login and screen locker case.
> 
> I should have actually payed more attention to the initial CL and review it
> (http://codereview.chromium.org/8711003) even though I was only cc'ed on it.

FYI, what happened was I had looked at the CL where the lock_view.cc example was
added: (Looked into this because I was curious why I would have written it
differently.)
http://codereview.chromium.org/8120014/diff/6008/ui/aura_shell/examples/lock_...
Which was later changed in this CL:
http://codereview.chromium.org/8399044/diff/3002/ui/aura_shell/examples/lock_...