Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: chrome/browser/about_flags_unittest.cc

Issue 8898039: Show all experiments, even those that are unavailable on the current platform (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix unit tests Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/resources/flags.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags_unittest.cc
diff --git a/chrome/browser/about_flags_unittest.cc b/chrome/browser/about_flags_unittest.cc
index a58cb466d95ec3bbedbe764f1ae7f72b5701355b..2cde57e045f187e4490612ba9f640d4a4582fcbb 100644
--- a/chrome/browser/about_flags_unittest.cc
+++ b/chrome/browser/about_flags_unittest.cc
@@ -223,7 +223,7 @@ TEST_F(AboutFlagsTest, PersistAndPrune) {
// Experiment 3 should show still be persisted in preferences though.
scoped_ptr<ListValue> switch_prefs(GetFlagsExperimentsData(&prefs_));
ASSERT_TRUE(switch_prefs.get());
- EXPECT_EQ(arraysize(kExperiments) - 1, switch_prefs->GetSize());
+ EXPECT_EQ(arraysize(kExperiments), switch_prefs->GetSize());
Tyler Breisacher (Chromium) 2011/12/19 23:23:26 The kExperiments array used for testing has a few
}
// Tests that switches which should have values get them in the command
@@ -273,7 +273,7 @@ TEST_F(AboutFlagsTest, CheckValues) {
// And it should persist
scoped_ptr<ListValue> switch_prefs(GetFlagsExperimentsData(&prefs_));
ASSERT_TRUE(switch_prefs.get());
- EXPECT_EQ(arraysize(kExperiments) - 1, switch_prefs->GetSize());
+ EXPECT_EQ(arraysize(kExperiments), switch_prefs->GetSize());
}
// Tests multi-value type experiments.
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/resources/flags.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698