Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: chrome/browser/resources/flags.html

Issue 8898039: Show all experiments, even those that are unavailable on the current platform (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Take out the raw text in the HTML Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/flags.html
diff --git a/chrome/browser/resources/flags.html b/chrome/browser/resources/flags.html
index 698f99181bd61705071e80530d6c058d6147ce5b..6f9d29e0272d6ef89b3e07cc7682346880d312b4 100644
--- a/chrome/browser/resources/flags.html
+++ b/chrome/browser/resources/flags.html
@@ -46,16 +46,19 @@
<table width="100%" cellpadding="2" cellspacing="0">
<!-- TODO(mkwst): This doesn't work exactly as expected for multivalue
experiments. See http://crbug.com/73730 -->
- <tr jsvalues="class:enabled ? 'experiment-enabled' : 'experiment-disabled'">
+ <tr jsvalues="class: supported ?
+ (enabled ? 'experiment-enabled' : 'experiment-disabled') :
+ 'experiment-unsupported'">
<td valign="top">
<div class="experiment-text">
<div>
<span class="experiment-name"
jscontent="name">NAME</span>
+ <span jscontent="supported_platforms.join(', ')">MAC, LINUX</span>
James Hawkins 2011/12/19 18:09:44 Remove inner content
Tyler Breisacher (Chromium) 2011/12/19 18:59:29 Done.
<div>
<span jsvalues=".innerHTML:description">
</div>
- <div jsdisplay="choices && choices.length > 0">
+ <div jsdisplay="supported && choices && choices.length > 0">
<select
class="experiment-select"
jsvalues=".internal_name:internal_name;.disabled:!enabled">
@@ -68,6 +71,7 @@
</div>
</div>
<div class="experiment-actions">
+ <div jsdisplay="!supported" i18n-content="flagsNotSupported"></div>
<!-- If enabled isn't set (i.e. in multi_type options),
then both jsdisplay tests fail, and we get no
rendering from this section. -->
@@ -75,14 +79,14 @@
<a
class="experiment-disable-link"
jsvalues=".internal_name:internal_name"
- jsdisplay="enabled"
+ jsdisplay="supported && enabled"
href="#"
i18n-content="disable"
>DISABLE</a>
<a
class="experiment-enable-link"
jsvalues=".internal_name:internal_name"
- jsdisplay="!enabled"
+ jsdisplay="supported && !enabled"
href="#"
i18n-content="enable"
>ENABLE</a>

Powered by Google App Engine
This is Rietveld 408576698