| Index: net/http/http_proxy_client_socket_pool_unittest.cc
|
| diff --git a/net/http/http_proxy_client_socket_pool_unittest.cc b/net/http/http_proxy_client_socket_pool_unittest.cc
|
| index e68de73d8b94db89642a00cd0015a91fb2b7ca2f..3d3fd5ee9b1556788927798cd8c744fe4bf0e414 100644
|
| --- a/net/http/http_proxy_client_socket_pool_unittest.cc
|
| +++ b/net/http/http_proxy_client_socket_pool_unittest.cc
|
| @@ -216,7 +216,7 @@ class HttpProxyClientSocketPoolTest : public TestWithHttpParam {
|
| scoped_refptr<DeterministicSocketData> data_;
|
| HttpProxyClientSocketPool pool_;
|
| ClientSocketHandle handle_;
|
| - TestOldCompletionCallback callback_;
|
| + TestCompletionCallback callback_;
|
| };
|
|
|
| //-----------------------------------------------------------------------------
|
| @@ -229,8 +229,8 @@ INSTANTIATE_TEST_CASE_P(HttpProxyClientSocketPoolTests,
|
| TEST_P(HttpProxyClientSocketPoolTest, NoTunnel) {
|
| Initialize(false, NULL, 0, NULL, 0, NULL, 0, NULL, 0);
|
|
|
| - int rv = handle_.Init("a", GetNoTunnelParams(), LOW, NULL, &pool_,
|
| - BoundNetLog());
|
| + int rv = handle_.Init("a", GetNoTunnelParams(), LOW, CompletionCallback(),
|
| + &pool_, BoundNetLog());
|
| EXPECT_EQ(OK, rv);
|
| EXPECT_TRUE(handle_.is_initialized());
|
| ASSERT_TRUE(handle_.socket());
|
| @@ -284,8 +284,8 @@ TEST_P(HttpProxyClientSocketPoolTest, NeedAuth) {
|
| arraysize(spdy_writes));
|
|
|
| data_->StopAfter(4);
|
| - int rv = handle_.Init("a", GetTunnelParams(), LOW, &callback_, &pool_,
|
| - BoundNetLog());
|
| + int rv = handle_.Init("a", GetTunnelParams(), LOW, callback_.callback(),
|
| + &pool_, BoundNetLog());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
| EXPECT_FALSE(handle_.is_initialized());
|
| EXPECT_FALSE(handle_.socket());
|
| @@ -304,7 +304,7 @@ TEST_P(HttpProxyClientSocketPoolTest, NeedAuth) {
|
| }
|
|
|
| TEST_P(HttpProxyClientSocketPoolTest, HaveAuth) {
|
| - // It's pretty much impossible to make the SPDY case becave synchronously
|
| + // It's pretty much impossible to make the SPDY case behave synchronously
|
| // so we skip this test for SPDY
|
| if (GetParam() == SPDY)
|
| return;
|
| @@ -323,8 +323,8 @@ TEST_P(HttpProxyClientSocketPoolTest, HaveAuth) {
|
| NULL, 0);
|
| AddAuthToCache();
|
|
|
| - int rv = handle_.Init("a", GetTunnelParams(), LOW, &callback_, &pool_,
|
| - BoundNetLog());
|
| + int rv = handle_.Init("a", GetTunnelParams(), LOW, callback_.callback(),
|
| + &pool_, BoundNetLog());
|
| EXPECT_EQ(OK, rv);
|
| EXPECT_TRUE(handle_.is_initialized());
|
| ASSERT_TRUE(handle_.socket());
|
| @@ -360,8 +360,8 @@ TEST_P(HttpProxyClientSocketPoolTest, AsyncHaveAuth) {
|
| arraysize(spdy_writes));
|
| AddAuthToCache();
|
|
|
| - int rv = handle_.Init("a", GetTunnelParams(), LOW, &callback_, &pool_,
|
| - BoundNetLog());
|
| + int rv = handle_.Init("a", GetTunnelParams(), LOW, callback_.callback(),
|
| + &pool_, BoundNetLog());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
| EXPECT_FALSE(handle_.is_initialized());
|
| EXPECT_FALSE(handle_.socket());
|
| @@ -382,8 +382,8 @@ TEST_P(HttpProxyClientSocketPoolTest, TCPError) {
|
|
|
| socket_factory().AddSocketDataProvider(data_.get());
|
|
|
| - int rv = handle_.Init("a", GetTunnelParams(), LOW, &callback_, &pool_,
|
| - BoundNetLog());
|
| + int rv = handle_.Init("a", GetTunnelParams(), LOW, callback_.callback(),
|
| + &pool_, BoundNetLog());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
| EXPECT_FALSE(handle_.is_initialized());
|
| EXPECT_FALSE(handle_.socket());
|
| @@ -407,8 +407,8 @@ TEST_P(HttpProxyClientSocketPoolTest, SSLError) {
|
| }
|
| socket_factory().AddSSLSocketDataProvider(ssl_data_.get());
|
|
|
| - int rv = handle_.Init("a", GetTunnelParams(), LOW, &callback_, &pool_,
|
| - BoundNetLog());
|
| + int rv = handle_.Init("a", GetTunnelParams(), LOW, callback_.callback(),
|
| + &pool_, BoundNetLog());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
| EXPECT_FALSE(handle_.is_initialized());
|
| EXPECT_FALSE(handle_.socket());
|
| @@ -432,8 +432,8 @@ TEST_P(HttpProxyClientSocketPoolTest, SslClientAuth) {
|
| }
|
| socket_factory().AddSSLSocketDataProvider(ssl_data_.get());
|
|
|
| - int rv = handle_.Init("a", GetTunnelParams(), LOW, &callback_, &pool_,
|
| - BoundNetLog());
|
| + int rv = handle_.Init("a", GetTunnelParams(), LOW, callback_.callback(),
|
| + &pool_, BoundNetLog());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
| EXPECT_FALSE(handle_.is_initialized());
|
| EXPECT_FALSE(handle_.socket());
|
| @@ -470,8 +470,8 @@ TEST_P(HttpProxyClientSocketPoolTest, TunnelUnexpectedClose) {
|
| arraysize(spdy_writes));
|
| AddAuthToCache();
|
|
|
| - int rv = handle_.Init("a", GetTunnelParams(), LOW, &callback_, &pool_,
|
| - BoundNetLog());
|
| + int rv = handle_.Init("a", GetTunnelParams(), LOW, callback_.callback(),
|
| + &pool_, BoundNetLog());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
| EXPECT_FALSE(handle_.is_initialized());
|
| EXPECT_FALSE(handle_.socket());
|
| @@ -511,8 +511,8 @@ TEST_P(HttpProxyClientSocketPoolTest, TunnelSetupError) {
|
| arraysize(spdy_writes));
|
| AddAuthToCache();
|
|
|
| - int rv = handle_.Init("a", GetTunnelParams(), LOW, &callback_, &pool_,
|
| - BoundNetLog());
|
| + int rv = handle_.Init("a", GetTunnelParams(), LOW, callback_.callback(),
|
| + &pool_, BoundNetLog());
|
| EXPECT_EQ(ERR_IO_PENDING, rv);
|
| EXPECT_FALSE(handle_.is_initialized());
|
| EXPECT_FALSE(handle_.socket());
|
|
|