Issue 8898029: Fix pyauto's fetch_prebuilt_pyauto.py to account for URL changes on official build site.

Issue 8898029: Fix pyauto's fetch_prebuilt_pyauto.py to account for URL changes on official build site. (Closed)

Created:
9 years ago by dennis_jeffrey

Modified:
9 years ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix pyauto's fetch_prebuilt_pyauto.py to account for URL changes on official build site. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114474

Patch Set 2 : Addressed review comments. #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -9 lines)			Patch
	M	chrome/test/pyautolib/fetch_prebuilt_pyauto.py	View	1	2 chunks	+17 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

LGTM http://codereview.chromium.org/8898029/diff/1/chrome/test/pyautolib/fetch_prebuilt_pyauto.py File chrome/test/pyautolib/fetch_prebuilt_pyauto.py (right): http://codereview.chromium.org/8898029/diff/1/chrome/test/pyautolib/fetch_prebuilt_pyauto.py#newcode57 chrome/test/pyautolib/fetch_prebuilt_pyauto.py:57: if 'index.html?path=' in self._url: Add a comment: # ...

9 years ago (2011-12-13 22:15:09 UTC) #2

dennis_jeffrey

9 years ago (2011-12-14 19:33:13 UTC) #3

Thank you for the review!  I'm submitting this now.

http://codereview.chromium.org/8898029/diff/1/chrome/test/pyautolib/fetch_pre...
File chrome/test/pyautolib/fetch_prebuilt_pyauto.py (right):

http://codereview.chromium.org/8898029/diff/1/chrome/test/pyautolib/fetch_pre...
chrome/test/pyautolib/fetch_prebuilt_pyauto.py:57: if 'index.html?path=' in
self._url:
On 2011/12/13 22:15:09, Nirnimesh wrote:
> Add a comment:
> 
> # Chromium continuous build archive has a non-standard format.

Done.

http://codereview.chromium.org/8898029/diff/1/chrome/test/pyautolib/fetch_pre...
chrome/test/pyautolib/fetch_prebuilt_pyauto.py:59: if self._url.endswith('/'):
On 2011/12/13 22:15:09, Nirnimesh wrote:
> self._url = self._url.rstrip('/')

Nice.

http://codereview.chromium.org/8898029/diff/1/chrome/test/pyautolib/fetch_pre...
chrome/test/pyautolib/fetch_prebuilt_pyauto.py:137: print 'Cleaning ' +
chrome_unzip_dir
On 2011/12/13 22:15:09, Nirnimesh wrote:
> it's pretty standard to use , with print

Changed.

Expand Messages | Collapse Messages