Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: chrome/browser/sync/engine/process_updates_command.cc

Issue 8898028: Revert 114090 - [Sync] Set HasCustomGroupsToChange() to true for ProcessUpdatesCommand (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/engine/process_updates_command.h" 5 #include "chrome/browser/sync/engine/process_updates_command.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 10 matching lines...) Expand all
21 namespace browser_sync { 21 namespace browser_sync {
22 22
23 using sessions::SyncSession; 23 using sessions::SyncSession;
24 using sessions::StatusController; 24 using sessions::StatusController;
25 using sessions::UpdateProgress; 25 using sessions::UpdateProgress;
26 26
27 ProcessUpdatesCommand::ProcessUpdatesCommand() {} 27 ProcessUpdatesCommand::ProcessUpdatesCommand() {}
28 ProcessUpdatesCommand::~ProcessUpdatesCommand() {} 28 ProcessUpdatesCommand::~ProcessUpdatesCommand() {}
29 29
30 bool ProcessUpdatesCommand::HasCustomGroupsToChange() const { 30 bool ProcessUpdatesCommand::HasCustomGroupsToChange() const {
31 return true; 31 // TODO(akalin): Set to true.
32 return false;
32 } 33 }
33 34
34 std::set<ModelSafeGroup> ProcessUpdatesCommand::GetGroupsToChange( 35 std::set<ModelSafeGroup> ProcessUpdatesCommand::GetGroupsToChange(
35 const sessions::SyncSession& session) const { 36 const sessions::SyncSession& session) const {
36 return session.GetEnabledGroupsWithVerifiedUpdates(); 37 return session.GetEnabledGroupsWithVerifiedUpdates();
37 } 38 }
38 39
39 bool ProcessUpdatesCommand::ModelNeutralExecuteImpl(SyncSession* session) { 40 bool ProcessUpdatesCommand::ModelNeutralExecuteImpl(SyncSession* session) {
40 const GetUpdatesResponse& updates = 41 const GetUpdatesResponse& updates =
41 session->status_controller().updates_response().get_updates(); 42 session->status_controller().updates_response().get_updates();
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 // Force application of this update, no matter what. 157 // Force application of this update, no matter what.
157 target_entry.Put(syncable::IS_UNAPPLIED_UPDATE, true); 158 target_entry.Put(syncable::IS_UNAPPLIED_UPDATE, true);
158 } 159 }
159 160
160 SyncerUtil::UpdateServerFieldsFromUpdate(&target_entry, update, name); 161 SyncerUtil::UpdateServerFieldsFromUpdate(&target_entry, update, name);
161 162
162 return SUCCESS_PROCESSED; 163 return SUCCESS_PROCESSED;
163 } 164 }
164 165
165 } // namespace browser_sync 166 } // namespace browser_sync
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698