Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 8898025: Extend --load-extension commandline to accept multiple (comma-separated) extensions. (Closed)

Created:
9 years ago by jvoung - send to chromium...
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Extend --load-extension commandline to accept multiple (comma-separated) extensions. R=asargent@chromium.org,mirandac@chromium.org BUG=107397 TEST=ExtensionsLoadMultipleTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114478

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add a test #

Total comments: 1

Patch Set 3 : space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -9 lines) Patch
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 2 6 chunks +57 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jvoung - send to chromium...
9 years ago (2011-12-13 20:08:32 UTC) #1
jvoung - send to chromium...
+aa and mirandac, since you looked at a similar change and at least mirandac is ...
9 years ago (2011-12-14 00:19:35 UTC) #2
Aaron Boodman
lgtm http://codereview.chromium.org/8898025/diff/1/chrome/browser/profiles/profile_impl.cc File chrome/browser/profiles/profile_impl.cc (right): http://codereview.chromium.org/8898025/diff/1/chrome/browser/profiles/profile_impl.cc#newcode472 chrome/browser/profiles/profile_impl.cc:472: extensions::UnpackedInstaller::Create(extension_service_.get())-> You could create one instance above the ...
9 years ago (2011-12-14 00:30:44 UTC) #3
asargent_no_longer_on_chrome
It would be nice to add a test for this. Probably the right thing to ...
9 years ago (2011-12-14 00:37:44 UTC) #4
asargent_no_longer_on_chrome
Oh and BTW, you'll need to add the new test class to chrome/chrome_tests.gypi (search for ...
9 years ago (2011-12-14 00:38:58 UTC) #5
jvoung - send to chromium...
Thanks for the pointer, I found a similar test that loaded one extension in "extension_startup_browsertest" ...
9 years ago (2011-12-14 03:00:43 UTC) #6
Miranda Callahan
On 2011/12/14 03:00:43, jvoung wrote: > Thanks for the pointer, I found a similar test ...
9 years ago (2011-12-14 08:48:31 UTC) #7
asargent_no_longer_on_chrome
LGTM http://codereview.chromium.org/8898025/diff/6001/chrome/browser/extensions/extension_startup_browsertest.cc File chrome/browser/extensions/extension_startup_browsertest.cc (right): http://codereview.chromium.org/8898025/diff/6001/chrome/browser/extensions/extension_startup_browsertest.cc#newcode230 chrome/browser/extensions/extension_startup_browsertest.cc:230: nit: remove space here
9 years ago (2011-12-14 17:52:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@google.com/8898025/11001
9 years ago (2011-12-14 18:26:37 UTC) #9
commit-bot: I haz the power
9 years ago (2011-12-14 19:40:06 UTC) #10
Change committed as 114478

Powered by Google App Engine
This is Rietveld 408576698