Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 8898023: Revert r113657 "win_release_OmitFramePointers=0 must explicitly pass /Oy-" (Closed)

Created:
9 years ago by M-A Ruel
Modified:
9 years ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, Reid Kleckner, Brad Chen
Visibility:
Public.

Description

Revert r113657 "win_release_OmitFramePointers=0 must explicitly pass /Oy-" We are suspecting this has side effects on official builds. If so, this is a configuration error. Trying out to be sure. TBR=timurrrr@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
Original review at: http://codereview.chromium.org/8890023/ I'm speculatively reverting the CL in case it helps with temporary ...
9 years ago (2011-12-13 18:30:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8898023/1
9 years ago (2011-12-13 18:31:22 UTC) #2
Timur Iskhodzhanov
LGTM if you re-land soon. +Reid just FYI
9 years ago (2011-12-13 19:45:33 UTC) #3
commit-bot: I haz the power
Change committed as 114251
9 years ago (2011-12-13 19:46:56 UTC) #4
Derek Bruening
9 years ago (2011-12-14 18:58:35 UTC) #5
On 2011/12/13 19:46:56, I haz the power (commit-bot) wrote:
> Change committed as 114251

Requesting an un-revert ASAP as this revert has caused us a lot of pain: we
added /Oy- for a reason.  Reverting it has caused us to chase a number of causes
of bot redness that have all ended up being from the lack of /Oy-.  This is
delaying our move to Memory FYI, and thus hurting our quarterly goals.

Powered by Google App Engine
This is Rietveld 408576698