Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: base/timer.cc

Issue 8898019: Remove Task inheritance from base::Timer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/timer.h ('k') | chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/timer.h" 5 #include "base/timer.h"
6 6
7 #include "base/bind.h"
8 #include "base/bind_helpers.h"
7 #include "base/message_loop.h" 9 #include "base/message_loop.h"
8 10
9 namespace base { 11 namespace base {
10 12
11 void BaseTimer_Helper::OrphanDelayedTask() { 13 void BaseTimer_Helper::OrphanDelayedTask() {
12 if (delayed_task_) { 14 if (delayed_task_) {
13 delayed_task_->timer_ = NULL; 15 delayed_task_->timer_ = NULL;
14 delayed_task_ = NULL; 16 delayed_task_ = NULL;
15 } 17 }
16 } 18 }
17 19
18 void BaseTimer_Helper::InitiateDelayedTask(TimerTask* timer_task) { 20 void BaseTimer_Helper::InitiateDelayedTask(TimerTask* timer_task) {
19 OrphanDelayedTask(); 21 OrphanDelayedTask();
20 22
21 delayed_task_ = timer_task; 23 delayed_task_ = timer_task;
22 delayed_task_->timer_ = this; 24 delayed_task_->timer_ = this;
23 MessageLoop::current()->PostDelayedTask( 25 MessageLoop::current()->PostDelayedTask(
24 timer_task->posted_from_, timer_task, 26 timer_task->posted_from_,
27 base::Bind(&TimerTask::Run, base::Owned(timer_task)),
25 static_cast<int>(timer_task->delay_.InMillisecondsRoundedUp())); 28 static_cast<int>(timer_task->delay_.InMillisecondsRoundedUp()));
26 } 29 }
27 30
28 } // namespace base 31 } // namespace base
OLDNEW
« no previous file with comments | « base/timer.h ('k') | chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698